Review main Merged

80304[BUGFIX] Fix paging in record list when pressing the Enter key

Andreas Kienast CR +2 V +2 Easy +8 −3 updated 09/07/23, 12:45

Commit message

Submitting the paging form in the record list's single table view was
broken as the "View webpage" button wasn't explictly defined as a
button, which in fact made it a submit button that opened the first
page in the record list in a new tab.

This patch does two things:

* The button element is now explicitly declared being a "dumb" button
* The JavaScript building the URL is simplified to use the existing URL
  in the form, which makes the data attribute that holds the "template"
  obsolete

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 08/02/23, 18:24

  2. core-ci voted on patch set 1 V -1 08/02/23, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44909

  3. Andreas Kienast uploaded patch set 2 V -1 08/03/23, 07:19

  4. core-ci voted on patch set 2 V +1 08/03/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44914

  5. Riccardo De Contardi commented on patch set 2 V +1 08/03/23, 12:25

    Tested on latest main with the "pages" table
  6. Andreas Kienast uploaded patch set 3 V +1 09/07/23, 08:52

  7. core-ci voted on patch set 3 V +1 09/07/23, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46334

  8. Georg Ringer voted on patch set 3 V +1 CR +1 09/07/23, 09:13

  9. Benni Mack voted on patch set 3 V +1 CR +1 09/07/23, 10:56

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 09/07/23, 12:32

  11. Andreas Kienast merged patch set 4 09/07/23, 12:45