Review main Merged

80307[BUGFIX] Fix error copying pages with outdated user permissions

Georg Ringer CR +2 V +2 Easy +1 −1 updated 12/16/23, 22:56

Commit message

If the user permissions contain DB tables which are not available
anymore, a notice is turned into an exception.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 08/03/23, 11:23

  2. Georg Ringer commented on patch set 1 08/03/23, 11:23

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/03/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44920

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 08/03/23, 18:50

  5. Stefan Froemken commented on patch set 1 CR +1 08/15/23, 06:30

    Just +1 for code review. "sys_collection" as example does not have a pid column and after removing sys_collection from core there is no TCA to resolve the relation back to pages. Currently, I don't get any working example which shows the PHP warning.
  6. Oliver Klee voted on patch set 1 CR +1 08/15/23, 08:09

  7. Stefan Bürk voted on patch set 1 V +1 CR +1 08/15/23, 13:40

  8. Benni Mack voted on patch set 1 CR +2 V +2 12/16/23, 22:56

  9. Benni Mack merged patch set 2 12/16/23, 22:56