Review main Merged

80324[TASK] Update naming in MvcPropertyMappingConfigurationService

Torben Hansen CR +2 V +2 Easy +19 −18 updated 08/05/23, 18:34

Commit message

With #88682 Extbase argument validation has switched from using PHP
serialize/unserialize to use json_encode/json_decode. The doc
comments and variables in the responsible class
`MvcPropertyMappingConfigurationService` however still use the
term "serialize", which is misleading and not correct anymore.

This change removes any occurrence of the term "serialize" and
replaces it with a term that suits better to the current
situation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1

Issues 2

Files 2

Review log 911

  1. Torben Hansen uploaded patch set 1 08/03/23, 20:13

  2. core-ci voted on patch set 1 V +1 08/03/23, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44964

  3. Torben Hansen wrote 08/05/23, 09:10

    Topic set to extbase
  4. Stefan Bürk voted on patch set 1 V +1 CR +1 08/05/23, 15:10

  5. Oliver Klee voted on patch set 1 V +1 CR +1 08/05/23, 18:22

  6. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 08/05/23, 18:27

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/05/23, 18:28

  8. Oliver Klee voted on patch set 2 V +1 CR +1 08/05/23, 18:28

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 08/05/23, 18:30

  10. Stefan Bürk merged patch set 3 08/05/23, 18:30

  11. core-ci voted on patch set 2 V +1 08/05/23, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45117