Review main Merged

80331[BUGFIX] Prevent exception on missing sys_csp_resolution table

Daniel Siepmann CR +2 V +2 Easy +16 −7 updated 08/05/23, 06:50

Commit message

Ignore missing sys_csp_resolution table and return empty
result instead of breaking the installation.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Daniel Siepmann uploaded patch set 1 08/03/23, 21:07

  2. Daniel Siepmann commented on patch set 1 08/03/23, 21:10

    Not sure if we should wrap all the calls in order to prevent the issue in further situations?
  3. core-ci voted on patch set 1 V +1 08/03/23, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44989

  4. Oliver Klee voted on patch set 1 CR +1 08/03/23, 21:47

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/23, 08:26

  6. Christian Kuhn commented on patch set 1 CR -1 08/04/23, 10:10

    unsure if we should catch this at all. that's most likely an upgrade issue? let's chat on this for a second these days, please ping stefan and me, @Daniel.
  7. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/04/23, 15:57

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/04/23, 15:57

  9. core-ci voted on patch set 2 V +1 08/04/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45078

  10. Markus Klein commented on patch set 2 08/04/23, 16:10

    Please be so kind and update the forge ticket as an answer to my question.
  11. Markus Klein commented on patch set 3 CR +1 V +1 08/04/23, 16:11

    Published edit on patch set 2.
  12. Christian Kuhn commented on patch set 3 08/04/23, 16:12

    Reply

    Done
  13. core-ci voted on patch set 3 V +1 08/04/23, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45081

  14. Markus Klein voted on patch set 3 V +1 CR +1 08/04/23, 16:35

  15. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/05/23, 06:50

  16. Anja Leichsenring merged patch set 4 08/05/23, 06:50