Review main Merged

80332[TASK] Add labels for search form inputs

Sven Liebert CR +2 V +2 Normal +44 −18 updated 08/04/23, 13:04

Commit message

To improve accessibility in the backend we provide visible and
non-visible labels for search form input fields to identify
form controls.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1418

  1. Sven Liebert uploaded patch set 1 08/03/23, 19:46

  2. core-ci voted on patch set 1 V +1 08/03/23, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44957

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/23, 09:02

  4. Josua Vogel voted on patch set 1 CR +1 08/04/23, 10:40

  5. Jasmina Ließmann commented on patch set 1 CR -1 08/04/23, 11:12

    On it.
  6. Sven Liebert commented on patch set 1 08/04/23, 11:27

    Reply

    Hi, could you explain please the problems with that patch so far, so I can fix it?
  7. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 08/04/23, 11:38

  8. Jasmina Ließmann commented on patch set 2 08/04/23, 11:41

    Reply

    No problems :) I just wanted to make sure the patch is not getting merged yet, because I found some other occurences while testing the patch.
  9. core-ci voted on patch set 2 V -1 08/04/23, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45051

  10. Jasmina Ließmann uploaded patch set 3 V -1 08/04/23, 12:26

  11. core-ci voted on patch set 3 V +1 08/04/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45058

  12. Jasmina Ließmann updated the commit message in patch set 4 V +1 08/04/23, 12:40

  13. Christian Kuhn voted on patch set 3 V +1 CR +1 08/04/23, 12:44

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 08/04/23, 12:47

  15. core-ci voted on patch set 4 V +1 08/04/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45062

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/04/23, 13:00

  17. Jasmina Ließmann voted on patch set 4 V +2 CR +2 08/04/23, 13:04

  18. Jasmina Ließmann merged patch set 5 08/04/23, 13:04