80374[FEATURE] Auto DB fields from TCA for type "file"
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 38
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_tca_select_items/ext_tables.sql+0 −1
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php2+20 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101553-Auto-createDBFieldsFromTCAColumns.rstnew+58 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+24 −0
- typo3/sysext/core/ext_tables.sql+0 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+14 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql+0 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/ControllerArgumentsMappingTestImport.csv+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/Fixtures/ActionControllerValidationTestImport.csv+11 −11
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CountTestImport.csv+7 −7
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/EnableFieldsTestImport.csv+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/InTestImport.csv+7 −7
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/IsDirtyTestImport.csv+6 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/LazyObjectStorageTestImport.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/OperatorTestImport.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/QueryLocalizedDataTestImport.csv+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/QueryParserTestImport.csv+11 −11
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestImport.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultAddPostToBlogInTheMiddle.csv+1 −1
Show 18 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultAddTagToPostInTheMiddle.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultAttachPostToBlogAtTheEnd.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultAttachTagToPostAtTheEnd.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultMovePostFromEndToTheMiddle.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultMoveTagFromEndToTheMiddle.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultRemoveLastPostFromBlog.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultRemoveLastTagFromPost.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultRemoveMiddlePostFromBlog.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RelationTestResultRemoveMiddleTagFromPost.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/RepositoryTestImport.csv+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/TranslationTestImport.csv+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/WorkspaceTestImport.csv+11 −11
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Storage/Fixtures/Typo3DbBackendTestImport.csv+11 −11
- typo3/sysext/frontend/ext_tables.sql+0 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+10 −10
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+10 −10
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+10 −10
- typo3/sysext/seo/ext_tables.sql+0 −2
Review log 2334
Show 79 earlier messages
-
Oliver Wand uploaded patch set 1 08/03/23, 21:49
-
Oliver Wand uploaded patch set 2 08/03/23, 21:53
-
Oliver Wand updated the commit message in patch set 3 08/03/23, 22:01
-
Andreas Kienast commented on patch set 3 08/03/23, 22:04
Can you please provide a ReST file that describes the feature? You may use https://forger.typo3.com/utilities/rst for this. -
Stefan Bürk commented on patch set 3 08/03/23, 22:10
DefaultTcaSchema.php:578Using length here is not needed. Database length for integer fields have more a visibilty meaning and not supporty by all dbms. Some are dropping it also. And we don't use it anyway. Despite the "length" it will always take the same size in the database anyway depending on the dbms architecture. -
Christian Kuhn commented on patch set 3 CR -1 08/03/23, 22:12
nice! will take care of some further organisational details of this one. -
core-ci voted on patch set 1 V -1 08/03/23, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45001
-
core-ci voted on patch set 2 V -1 08/03/23, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45008
-
Tobias Liebig uploaded patch set 4
CR -108/03/23, 22:25
-
core-ci voted on patch set 3 V -1 08/03/23, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45009
-
core-ci voted on patch set 4 V -1 08/03/23, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45010
-
Christian Kuhn uploaded patch set 5
V -108/04/23, 16:37 -
Christian Kuhn commented on patch set 4 08/04/23, 16:37
DefaultTcaSchema.php:578ReplyDone -
Christian Kuhn commented on patch set 5 CR -1 08/04/23, 16:37
still on it. -
core-ci voted on patch set 5 V -1 08/04/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45082
-
Christian Kuhn rebased onto patch set 6
CR -1V -108/08/23, 10:42 -
Christian Kuhn commented on patch set 6 CR -1 08/08/23, 10:43
actively on it, now. -
core-ci voted on patch set 6 V -1 08/08/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45235
-
Christian Kuhn uploaded patch set 7
CR -1V -108/08/23, 11:31 -
core-ci voted on patch set 7 V -1 08/08/23, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45238
-
Christian Kuhn uploaded patch set 8
V -108/08/23, 12:34 -
core-ci voted on patch set 8 V +1 08/08/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45239
-
Christian Kuhn commented on patch set 8 CR -1 08/08/23, 12:47
green. nice. will finish and un-WIP soon. -
Christian Kuhn uploaded patch set 9
CR -1V +108/08/23, 16:04 -
core-ci voted on patch set 9 V +1 08/08/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45246
-
Christian Kuhn uploaded patch set 10
V +108/08/23, 16:56 -
Christian Kuhn uploaded patch set 11 08/08/23, 16:59
-
core-ci voted on patch set 10 V +1 08/08/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45248
-
core-ci voted on patch set 11 V +1 08/08/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45249
-
Christian Kuhn voted on patch set 11 V +1 CR +1 08/08/23, 17:11
-
Anja Leichsenring voted on patch set 11 V +1 CR +1 08/08/23, 17:27
-
Stefan Bürk voted on patch set 11 V +1 CR +1 08/08/23, 17:31
-
Stefan Bürk voted on patch set 11 V +2 CR +2 08/08/23, 17:37
-
Stefan Bürk merged patch set 12 08/08/23, 17:37