Review main Merged

80374[FEATURE] Auto DB fields from TCA for type "file"

Oliver Wand CR +2 V +2 Hard +235 −138 updated 08/08/23, 17:37

Commit message

Tables with TCA columns set to type="file" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is the first patch in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=file.
It goes through various functional test related .csv
fields, and adapts a broken TCA configuration in the
blog_example fixture extension revealed by this change.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 38

Show 18 more files

Review log 2334

Show 79 earlier messages
  1. Oliver Wand uploaded patch set 1 08/03/23, 21:49

  2. Oliver Wand uploaded patch set 2 08/03/23, 21:53

  3. Oliver Wand updated the commit message in patch set 3 08/03/23, 22:01

  4. Andreas Kienast commented on patch set 3 08/03/23, 22:04

    Can you please provide a ReST file that describes the feature? You may use https://forger.typo3.com/utilities/rst for this.
  5. Stefan Bürk commented on patch set 3 08/03/23, 22:10

    DefaultTcaSchema.php:578

    Using length here is not needed. Database length for integer fields have more a visibilty meaning and not supporty by all dbms. Some are dropping it also. And we don't use it anyway. Despite the "length" it will always take the same size in the database anyway depending on the dbms architecture.
  6. Christian Kuhn commented on patch set 3 CR -1 08/03/23, 22:12

    nice! will take care of some further organisational details of this one.
  7. core-ci voted on patch set 1 V -1 08/03/23, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45001

  8. core-ci voted on patch set 2 V -1 08/03/23, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45008

  9. Tobias Liebig uploaded patch set 4 CR -1 08/03/23, 22:25

  1. core-ci voted on patch set 3 V -1 08/03/23, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45009

  2. core-ci voted on patch set 4 V -1 08/03/23, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45010

  3. Christian Kuhn uploaded patch set 5 V -1 08/04/23, 16:37

  4. Christian Kuhn commented on patch set 4 08/04/23, 16:37

    DefaultTcaSchema.php:578 Reply

    Done
  5. Christian Kuhn commented on patch set 5 CR -1 08/04/23, 16:37

    still on it.
  6. core-ci voted on patch set 5 V -1 08/04/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45082

  7. Christian Kuhn rebased onto patch set 6 CR -1 V -1 08/08/23, 10:42

  8. Christian Kuhn commented on patch set 6 CR -1 08/08/23, 10:43

    actively on it, now.
  9. core-ci voted on patch set 6 V -1 08/08/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45235

  10. Christian Kuhn uploaded patch set 7 CR -1 V -1 08/08/23, 11:31

  11. core-ci voted on patch set 7 V -1 08/08/23, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45238

  12. Christian Kuhn uploaded patch set 8 V -1 08/08/23, 12:34

  13. core-ci voted on patch set 8 V +1 08/08/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45239

  14. Christian Kuhn commented on patch set 8 CR -1 08/08/23, 12:47

    green. nice. will finish and un-WIP soon.
  15. Christian Kuhn uploaded patch set 9 CR -1 V +1 08/08/23, 16:04

  16. core-ci voted on patch set 9 V +1 08/08/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45246

  17. Christian Kuhn uploaded patch set 10 V +1 08/08/23, 16:56

  18. Christian Kuhn uploaded patch set 11 08/08/23, 16:59

  19. core-ci voted on patch set 10 V +1 08/08/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45248

  20. core-ci voted on patch set 11 V +1 08/08/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45249

  21. Christian Kuhn voted on patch set 11 V +1 CR +1 08/08/23, 17:11

  22. Anja Leichsenring voted on patch set 11 V +1 CR +1 08/08/23, 17:27

  23. Stefan Bürk voted on patch set 11 V +1 CR +1 08/08/23, 17:31

  24. Stefan Bürk voted on patch set 11 V +2 CR +2 08/08/23, 17:37

  25. Stefan Bürk merged patch set 12 08/08/23, 17:37