Review main Merged

80381[BUGFIX] Only treat numerical route arguments as possible UIDs

Christian Spoo CR +2 V +2 Easy +50 −0 updated 08/05/23, 21:08

Commit message

`PersistedAliasMapper` and `PersistentPatternMapper` both should only
use int-like string route arguments as possible UID candidates for the
following DB lookup.

Thus, check if the arguments are truly numerical before passing them to
the database queries.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Christian Spoo uploaded patch set 1 08/04/23, 07:55

  2. core-ci voted on patch set 1 V +1 08/04/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45021

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/23, 11:37

  4. Christian Kuhn voted on patch set 1 CR +1 08/04/23, 12:53

  5. Oliver Klee commented on patch set 1 CR -1 08/05/23, 19:31

    on it
  6. Oliver Klee uploaded patch set 2 CR +1 V +1 08/05/23, 20:13

  7. Oliver Klee commented on patch set 2 V +1 CR +1 08/05/23, 20:13

    Reply

    Done
    Added regression tests.
  8. Oliver Klee updated the commit message in patch set 3 CR +1 V +1 08/05/23, 20:14

  9. Oliver Klee voted on patch set 3 V +1 CR +1 08/05/23, 20:14

  10. core-ci voted on patch set 2 V +1 08/05/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45119

  11. core-ci voted on patch set 3 V +1 08/05/23, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45123

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 08/05/23, 20:56

  13. Stefan Bürk voted on patch set 3 V +2 CR +2 08/05/23, 21:08

  14. Stefan Bürk merged patch set 4 08/05/23, 21:08