Review main Merged

80396[TASK] Mark PasswordPolicyValidator as public API

Torben Hansen CR +2 V +2 Easy +0 −2 updated 08/04/23, 16:09

Commit message

With the introduction of configurable password policies, the
`PasswordPolicyValidator` has been introduced. The class is
however marked as `@internal`, which basically was a mistake.
3rd party extensions providing users the possibility to change
a password should be able to validate the new password against
the globally configured password policy by using the
`isValidPassword()` method in the `PasswordPolicyValidator` class.

The change therefore mark the class as public API by removing
the `@internal` annotation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 08/04/23, 14:38

  2. core-ci voted on patch set 1 V +1 08/04/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45076

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/04/23, 15:41

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/04/23, 16:09

  5. Christian Kuhn merged patch set 2 08/04/23, 16:09