Review main Merged

80421[DOCS] Document known issues with ext:linkvalidator

Rémy DANIEL CR +2 V +2 Normal +55 −2 updated 08/09/23, 12:39

Commit message

Linkvalidator extension has a couple of known issues,
especially with external link checking.

Those issues are now documented, so integrators can
acknowledge them and implement counter-measures.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 911

  1. Rémy DANIEL uploaded patch set 1 08/06/23, 09:53

  2. core-ci voted on patch set 1 V +1 08/06/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45143

  3. Oliver Klee voted on patch set 1 V +1 CR +1 08/06/23, 10:02

  4. Chris Müller voted on patch set 1 V +1 CR +1 08/06/23, 11:16

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/06/23, 15:36

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/06/23, 15:36

  7. Oliver Klee voted on patch set 2 V +1 CR +1 08/06/23, 15:42

  8. core-ci voted on patch set 2 V +1 08/06/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45151

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 08/06/23, 16:32

  10. Stefan Bürk merged patch set 3 08/06/23, 16:49

  11. Sybille Peters commented on patch set 3 08/09/23, 12:39

    Just saw this now so didn't get a chance to review. Thanks for adding this. One remark about the "false positive" vs. "false negative" because I used the term differently: I usually call these "false positives" and not "false negatives". It depends on which way you look at it (so both would be correct) but if you consider we are testing for the brokenness of a link, it is the same as if we are testing for a disease (where the term "false positive" is usually used). In this case it does not matter whether it is a good thing or bad, just if the condition we test for is true or not. In the case of link checking we can call it "false positive" if a link is reported broken but is not. (if we consider the "link is broken" the condition we test for). Compare also tests for diseases where the same applies, e.g. "False positive refers to a test result that tells you a disease or condition is present, when in reality, there is no disease." https://www.verywellhealth.com/false-positive-797213 or wikipedia: "A false positive is an error in binary classification in which a test result incorrectly indicates the presence of a condition (such as a disease when the disease is not present), while a false negative is the opposite error, where the test result incorrectly indicates the absence of a condition when it is actually present" https://en.wikipedia.org/wiki/False_positives_and_false_negatives