Review main Merged Breaking

80422[!!!][FEATURE] Introduce PSR-14 ModifyRecordOverlayIconIdentifierEvent

Oli Bartsch CR +2 V +2 Normal +239 −9 updated 08/07/23, 07:53

Commit message

This introduces a new PSR-14 event, enabling extension
authors to modify the overlay icon identifier of any
record icon.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Core\Imaging\IconFactory']['overrideIconOverlay']
which is therefore now removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Oli Bartsch uploaded patch set 1 08/06/23, 12:36

  2. core-ci voted on patch set 1 V +1 08/06/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45148

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 08/06/23, 16:38

  4. Oli Bartsch uploaded patch set 2 CR +1 V +1 08/07/23, 06:22

  5. core-ci voted on patch set 2 V -1 08/07/23, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45163

  6. Oli Bartsch uploaded patch set 3 V -1 08/07/23, 06:34

  7. core-ci voted on patch set 3 V +1 08/07/23, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45164

  8. Benni Mack voted on patch set 3 V +1 CR +1 08/07/23, 07:01

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 08/07/23, 07:44

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 08/07/23, 07:53

  11. Oli Bartsch merged patch set 4 08/07/23, 07:53