80434[TASK] Remove TCA MM_hasUidField
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php1+7 −7
- typo3/sysext/core/Classes/Database/RelationHandler.php6+13 −12
- typo3/sysext/core/Classes/Migrations/TcaMigration.php3+19 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101554-ObsoleteTCAMM_hasUidField.rstnew+45 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_offer.php+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_price.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+62 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/irre_tutorial.csv+8 −8
Review log 1318
-
Christian Kuhn uploaded patch set 1 08/07/23, 13:42
-
core-ci voted on patch set 1 V -1 08/07/23, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45192
-
Christian Kuhn uploaded patch set 2
V -108/07/23, 14:43 -
core-ci voted on patch set 2 V +1 08/07/23, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45194
-
Christian Kuhn uploaded patch set 3
V +108/08/23, 07:22 -
core-ci voted on patch set 3 V +1 08/08/23, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45220
-
Christian Kuhn uploaded patch set 4
V +108/08/23, 08:00 -
core-ci voted on patch set 4 V +1 08/08/23, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45221
-
Oliver Klee commented on patch set 4 V +1 08/08/23, 08:26
Awesome! Added some comments on smaller things.RelationHandler.php:128If we're introducing a new property anyway (in place of the old property), should we directly make it private?DefaultTcaSchema.php:616I like this renaming! It makes things more clear.TcaMigration.php:1471Do we still need the `isset` if we have the fallback for the `is_array`? -
Benni Mack commented on patch set 4 08/08/23, 08:53
RelationHandler.php:128Replywhy?TcaMigration.php:1471Replyagree -
Oliver Klee commented on patch set 4 08/08/23, 09:12
RelationHandler.php:128ReplyI talked with Lolli about this (in general) at T3DD23, and we both were inclined to use `private` more and only expose via `protected` to subclasses if we explicitly wanted to make them (subclass) API (instead of the other way around, where everything is `protected`, which automatically makes many refactorings breaking). -
Christian Kuhn commented on patch set 4 08/08/23, 09:28
RelationHandler.php:128ReplyI'd keep it like that for now - I'd rather refactor the whole class later to remove most of the properties anyways: There is no point in deriving all this state from the incoming start() $config array.TcaMigration.php:1471ReplyDone -
Christian Kuhn uploaded patch set 5
V +108/08/23, 09:29 -
core-ci voted on patch set 5 V +1 08/08/23, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45229
-
Oliver Klee commented on patch set 5 V +1 CR +1 08/08/23, 09:42
RelationHandler.php:128ReplyAck -
Benni Mack commented on patch set 5 08/08/23, 10:16
RelationHandler.php:128ReplyI disagree on that topic. By using private but people would need a workaround in their extension they would need to copy more and more code in to their XCLASS. XCLASS, protected properties (except on Abstract methods), nor using "@internal" classes nor patching via composer patches are neither part of the bw/compat promise, but private makes lives easier if people would need to adapt - but then "they are on their own" -
Benni Mack voted on patch set 5 V +2 CR +2 08/08/23, 10:16
-
Benni Mack merged patch set 6 08/08/23, 10:16