Review main Merged

80455[TASK] Mock interfaces instead of abstract classes

Oliver Klee CR +2 V +2 Easy +15 −16 updated 08/08/23, 11:10

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow current best practices.

This changes tackles the classes where we can mock an interface
instead of an abstract class, allowing us to use `createMock` instead
of `getMockForAbstractClass`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 67

  1. Oliver Klee uploaded patch set 1 08/08/23, 09:02

  2. Oliver Klee wrote 08/08/23, 09:02

    Topic set to phpunit
  3. core-ci voted on patch set 1 V +1 08/08/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45226

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/08/23, 10:40

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 08/08/23, 10:43

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 08/08/23, 11:10

  7. Christian Kuhn merged patch set 2 08/08/23, 11:10