Review main Merged

80459[BUGFIX] Make sure that only strings get trimExploded

Oliver Klee CR +2 V +2 Easy +4 −4 updated 08/08/23, 18:21

Commit message

This change fixes places where the code violates the contract.
Also, the change will avoid type errors when the `GeneralUtility`
array functions are switched to native type declarations.

All of these changes fix places where the acceptance test
break with the GU array methods using native type declarations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Oliver Klee uploaded patch set 1 08/08/23, 10:52

  2. Oliver Klee commented on patch set 1 08/08/23, 10:56

    BackendUtility.php:1585

    Note on this line: The actual `trimExplode` happens in `getLabelsFromItemsList`, which already has a `string` type annotation (not declaration!) for the third parameter. So we're fixing the contract violation in this place instead of treating the type annotation as unreliable.
  3. core-ci voted on patch set 1 V +1 08/08/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45236

  4. Oliver Klee commented on patch set 1 08/08/23, 11:00

    This change fixes the breakage from introducing native type declarations for the GU array methods: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80247
  5. Christian Kuhn updated the commit message in patch set 2 V +1 08/08/23, 18:04

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/08/23, 18:04

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 08/08/23, 18:06

  8. core-ci voted on patch set 2 V +1 08/08/23, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45253

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/08/23, 18:21

  10. Christian Kuhn merged patch set 3 08/08/23, 18:21