80461[BUGFIX] TS copy operator handles existing reference
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Tomek Woldański +1
-
Verified V +2 Done
- Christian Kuhn +2
- Tomek Woldański +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1522
-
Tomek Woldański uploaded patch set 1 08/08/23, 13:39
-
core-ci voted on patch set 1 V -1 08/08/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45241
-
Łukasz Uznański commented on patch set 2
V -108/08/23, 14:11Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 08/08/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45242
-
Christian Kuhn uploaded patch set 3
V +108/10/23, 10:23 -
Christian Kuhn rebased onto patch set 4 08/10/23, 10:23
-
Christian Kuhn updated the commit message in patch set 5 08/10/23, 10:25
-
core-ci voted on patch set 3 V +1 08/10/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45323
-
core-ci voted on patch set 4 V +1 08/10/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45324
-
core-ci voted on patch set 5 V +1 08/10/23, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45325
-
Christian Kuhn uploaded patch set 6
V +108/10/23, 10:54 -
core-ci voted on patch set 6 V +1 08/10/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45327
-
Christian Kuhn commented on patch set 6 V +1 CR +1 08/10/23, 13:00
I think that's fine but would like to wait for Tomek to re-check. -
Tymoteusz Motylewski commented on patch set 6 08/10/23, 13:23
AbstractAstBuilder.php:112note -> node ? -
Christian Kuhn uploaded patch set 7
CR +1V +108/10/23, 13:25 -
Christian Kuhn commented on patch set 6 V +1 CR +1 08/10/23, 13:25
AbstractAstBuilder.php:112ReplyDone. Thx. -
Christian Kuhn voted on patch set 7 V +1 CR +1 08/10/23, 13:26
-
Stefan Bürk voted on patch set 7 CR +1 08/10/23, 13:32
-
core-ci voted on patch set 7 V +1 08/10/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45337
-
Tomek Woldański commented on patch set 7 V +1 CR +1 08/10/23, 13:54
Reply
I applied refactored code onto TYPO3 12.4 instance with headless and it's working as expected! -
Christian Kuhn voted on patch set 7 V +2 CR +2 08/10/23, 14:11
-
Christian Kuhn merged patch set 8 08/10/23, 14:11