Review main Merged

80464[TASK] Simplify EXT:lowlevel Full Search Controller

Benni Mack CR +2 V +2 Normal +57 −114 updated 08/09/23, 20:07

Commit message

* Avoids static methods (which were copied from BackendUtility)
* Uses proper UriBuilder everywhere
* Moves some HTML rendering into Fluid
* Removes unused methods

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benni Mack uploaded patch set 1 08/08/23, 19:25

  2. core-ci voted on patch set 1 V -1 08/08/23, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45259

  3. Benni Mack uploaded patch set 2 V -1 08/08/23, 19:43

  4. core-ci voted on patch set 2 V +1 08/08/23, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45260

  5. Benni Mack updated the commit message in patch set 3 V +1 08/08/23, 21:03

  6. core-ci voted on patch set 3 V +1 08/08/23, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45264

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/09/23, 07:01

  8. Oliver Klee commented on patch set 3 08/09/23, 07:32

    CustomSearch.html:48

    Won't this then hide the message if I searched for the string "0" and got no results?
  9. Benni Mack uploaded patch set 4 CR +1 V +1 08/09/23, 16:04

  10. Benni Mack commented on patch set 3 08/09/23, 16:04

    CustomSearch.html:48 Reply

    I kept the old way.
  11. core-ci voted on patch set 4 V +1 08/09/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45284

  12. Oliver Klee voted on patch set 4 CR +1 08/09/23, 18:56

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 08/09/23, 19:18

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 08/09/23, 20:03

  15. Benni Mack voted on patch set 4 V +2 CR +2 08/09/23, 20:07

  16. Benni Mack merged patch set 5 08/09/23, 20:07