Review main Merged

80465[TASK] Allow table without columns in ext_tables.sql

Christian Kuhn CR +2 V +2 Normal +49 −41 updated 08/09/23, 05:41

Commit message

When core DefaultTcaSchema auto creates more and more
column definitions, ext_tables.sql can end up with
a table definition without columns:

CREATE TABLE tx_foo (
);

This would be invalid as such in most DBMS since
tables usually must have at least one column.

However, it is a valid definition in the scope of
ext_tables.sql files when the core enriches fields
from TCA.

The parser currently chokes on tables without
columns, which is fixed with the patch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/09/23, 05:17

  2. core-ci voted on patch set 1 V +1 08/09/23, 05:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45270

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/09/23, 05:36

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 08/09/23, 05:41

  5. Stefan Bürk merged patch set 2 08/09/23, 05:41