80470[TASK] Replace usages of getMockForAbstractClass in EXT:core
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Andreas Nedbal +1
- Lina Wolf +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Andreas Nedbal +1
- Lina Wolf +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 13
- Build/phpstan/phpstan-baseline.neon+1 −1
- typo3/sysext/core/Tests/Unit/Log/Processor/Fixtures/TestingMemoryProcessor.phpnew+32 −0
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractMemoryProcessorTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Collection/Fixtures/TestingFileCollection.phpnew+31 −0
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/Driver/Fixtures/TestingDriver.phpnew+281 −0
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractDriverTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/DriverRegistryTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Resource/Fixtures/TestingFile.phpnew+41 −0
- typo3/sysext/core/Tests/Unit/Resource/Repository/Fixtures/TestingRepository.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.php1+2 −22
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+2 −10
Review log 1520
-
Oliver Klee uploaded patch set 1 08/09/23, 11:06
-
Oliver Klee uploaded patch set 2 08/09/23, 11:08
-
Oliver Klee wrote 08/09/23, 11:08
Topic set to phpunit -
Oliver Klee commented on patch set 2 CR -1 08/09/23, 11:10
On it. -
Oliver Klee uploaded patch set 3
CR -108/09/23, 11:13 -
core-ci voted on patch set 1 V -1 08/09/23, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45277
-
core-ci voted on patch set 2 V -1 08/09/23, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45278
-
Oliver Klee uploaded patch set 4 08/09/23, 11:20
-
core-ci voted on patch set 3 V -1 08/09/23, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45279
-
core-ci voted on patch set 4 V +1 08/09/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45280
-
Jörg Bösche voted on patch set 4 CR +1 08/10/23, 12:56
-
Oliver Klee commented on patch set 4 08/10/23, 14:44
How to verify: Check that the unit tests are green (e.g., in CI). -
Christian Kuhn commented on patch set 4 08/10/23, 15:09
AbstractRepositoryTest.php:65let's remove it right away: findByUid() has an early canBeInterpretedAsInteger() ... there is little reason to create lots of fuzz about it with a test. Also, there is the above test that checks if the exception is thrown. -
Christian Kuhn uploaded patch set 5
CR +1V +108/10/23, 15:11 -
Christian Kuhn voted on patch set 5 V +1 CR +1 08/10/23, 15:19
-
core-ci voted on patch set 5 V +1 08/10/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45345
-
Lina Wolf commented on patch set 5 V +1 CR +1 08/10/23, 18:35
Looks good, thanks for taking care of this -
Andreas Nedbal voted on patch set 5 V +1 CR +1 08/10/23, 18:36
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 08/10/23, 18:36
-
Anja Leichsenring merged patch set 6 08/10/23, 18:36