Review main Merged

80471[TASK] Declare TypeScript types for global TYPO3 object

Benjamin Franzke CR +2 V +2 Normal +53 −37 updated 08/10/23, 09:21

Commit message

Missing declarations caused some method calls
and assignments to not be type checked, as all
members of the (top.|window.)TYPO3 object were
declared to `any`.
This actually revealed some invalid API usage.
which is fixed as a drive-by. (No real bugs were found,
as type checking in the APIs caught/ignored such cases)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 68

  1. Benjamin Franzke uploaded patch set 1 08/09/23, 14:17

  2. core-ci voted on patch set 1 V +1 08/09/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45281

  3. Benjamin Franzke uploaded patch set 2 V +1 08/10/23, 07:22

  4. core-ci voted on patch set 2 V +1 08/10/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45308

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/10/23, 08:53

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 08/10/23, 08:57

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/10/23, 09:09

  8. Benjamin Franzke merged patch set 3 08/10/23, 09:21