80492[WIP][TASK] Replace `php -S` with apache2 and libapache-php
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 12
- Build/Scripts/runTests.sh+22 −14
- Build/gitlab-ci.yml+4 −4
- typo3/sysext/core/Classes/Registry.php+15 −5
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+6 −16
- typo3/sysext/core/Tests/Acceptance/Application/Page/PageModuleCest.php+2 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+40 −6
- typo3/sysext/core/Tests/Acceptance/Application.suite.yml+2 −2
- typo3/sysext/core/Tests/Acceptance/Install.suite.yml+2 −2
- typo3/sysext/core/Tests/parameters.yml+1 −1
- typo3/sysext/install/Tests/Functional/Service/EnableFileServiceTest.php+1 −1
- composer.json+1 −1
- composer.lock+7 −8
Review log 1322
-
Stefan Bürk uploaded patch set 1 08/09/23, 14:23
-
core-ci voted on patch set 1 V +1 08/09/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45282
-
Mathias Brodala commented on patch set 1 08/10/23, 07:05
Just curious: why? -
Stefan Bürk commented on patch set 1 08/10/23, 08:49
Reply
Multiple reasons. Unblocking features to be testable and other things. php -S does not support some things we need in the future to have in the testing. -
Stefan Bürk uploaded patch set 2
V +108/10/23, 18:02 -
core-ci voted on patch set 2 V +1 08/10/23, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45350
-
Benni Mack commented on patch set 2 08/10/23, 18:24
Reply
A few reasons from my side: * We cannot test .htaccess stuff * I want to know if fpm is faster than php -S on acceptance tests -
Stefan Bürk uploaded patch set 3
V +108/11/23, 09:11 -
Stefan Bürk uploaded patch set 4 08/11/23, 09:12
-
core-ci voted on patch set 3 V -1 08/11/23, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45370
-
core-ci voted on patch set 4 V -1 08/11/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45371
-
Stefan Bürk uploaded patch set 5
V -108/11/23, 12:42 -
core-ci voted on patch set 5 V -1 08/11/23, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45384
-
Stefan Bürk uploaded patch set 6
V -108/11/23, 13:49 -
core-ci voted on patch set 6 V +1 08/11/23, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45388
-
Stefan Bürk uploaded patch set 7
V +108/11/23, 14:52 -
core-ci voted on patch set 7 V +1 08/11/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45393
-
Stefan Bürk rebased onto patch set 8
V +108/14/23, 07:22 -
core-ci voted on patch set 8 V +1 08/14/23, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45468
-
Stefan Bürk uploaded patch set 9
V +108/16/23, 16:18 -
core-ci voted on patch set 9 V +1 08/16/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45565
-
Stefan Bürk abandoned the change 08/22/23, 05:45
in favor for fpm approach