Review main Merged

80495[TASK] Modernize EM FileHandlingUtility

Christian Kuhn CR +2 V +2 Hard +204 −215 updated 08/09/23, 21:00

Commit message

The extension manager `@internal` class `FileHandlingUtility`
has a circular dependency to `InstallUtility`: Both inject
each other.

The patch resolves this by implementing
`reloadPackageInformation()` in `FileHandlingUtility` on
its own.

The class is modernized along the way with more type
hints, constructor property promotion, having all
public methods on top, and a unit test cleanup.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/09/23, 19:13

  2. Christian Kuhn uploaded patch set 2 08/09/23, 19:17

  3. core-ci voted on patch set 1 V -1 08/09/23, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45288

  4. core-ci voted on patch set 2 V +1 08/09/23, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45289

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/09/23, 19:43

  6. core-ci voted on patch set 3 V +1 08/09/23, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45292

  7. Stefan Bürk voted on patch set 3 CR +1 08/09/23, 20:16

  8. Stefan Bürk voted on patch set 3 V +1 08/09/23, 20:22

  9. Benni Mack voted on patch set 3 V +1 CR +1 08/09/23, 20:38

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 08/09/23, 21:00

  11. Christian Kuhn merged patch set 4 08/09/23, 21:00