Review main Merged

80498[TASK] Modernize ext:core ext_tables.sql AST classes

Christian Kuhn CR +2 V +2 Hard +125 −350 updated 08/10/23, 07:38

Commit message

Classes in TYPO3\CMS\Core\Database\Schema\Parser\AST
are intermediate DTO's created by the ext_tables.sql
parser to transfer them into doctrine objects.

They are modernized with more type hints and
constructor property promotion to be more
reliable with upcoming refactorings.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/09/23, 22:11

  2. core-ci voted on patch set 1 V +1 08/09/23, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45303

  3. Oliver Klee voted on patch set 1 V +1 08/09/23, 22:26

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/10/23, 06:06

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/10/23, 07:38

  6. Anja Leichsenring merged patch set 2 08/10/23, 07:38