80498[TASK] Modernize ext:core ext_tables.sql AST classes
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 17
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateColumnDefinitionItem.php+26 −93
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateDefinition.php+7 −10
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateForeignKeyDefinitionItem.php+9 −31
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateIndexDefinitionItem.php+14 −72
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateTableClause.php+8 −19
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateTableStatement.php+10 −26
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/Identifier.php+7 −17
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/IndexColumnName.php+8 −24
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/ReferenceDefinition.php+14 −36
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/AbstractDataTypeBaseTestCase.php+4 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionAttributesTest.php+3 −4
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionItemTest.php+2 −4
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ForeignKeyDefinitionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/IndexDefinitionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ReferenceDefinitionTest.php+5 −3
Review log 56
-
Christian Kuhn uploaded patch set 1 08/09/23, 22:11
-
core-ci voted on patch set 1 V +1 08/09/23, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45303
-
Oliver Klee voted on patch set 1 V +1 08/09/23, 22:26
-
Andreas Kienast voted on patch set 1 V +1 CR +1 08/10/23, 06:06
-
Anja Leichsenring voted on patch set 1 V +2 CR +2 08/10/23, 07:38
-
Anja Leichsenring merged patch set 2 08/10/23, 07:38