Review main Merged

80499[TASK] De-mess EM InstallUtility a bit

Christian Kuhn CR +2 V +2 Hard +87 −382 updated 08/10/23, 07:46

Commit message

Service classes in Extensionmanager\Utility
are a great example on "when class abstraction
goes wrong" - we're fighting with those for
lots of major versions already.

To tame this mess, this first patch applies a rather
straight streamlining to InstallUtility: Use constructor
property promotion, move public methods up in the class,
remove heavy-mocking and useless unit tests that
only check if certain sub-methods are called.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/09/23, 22:50

  2. core-ci voted on patch set 1 V +1 08/09/23, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45304

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/10/23, 06:07

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/10/23, 07:46

  5. Anja Leichsenring merged patch set 2 08/10/23, 07:46