80500[TASK] Eliminate eslint warnings
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 38
- Build/Sources/TypeScript/backend/element/immediate-action-element.ts+2 −2
- Build/Sources/TypeScript/backend/event/trigger-request.ts1+14 −8
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+20 −24
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+35 −43
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+19 −24
- Build/Sources/TypeScript/backend/form-engine/element/password-element.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/inline-relation/ajax-dispatcher.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/inline-relation/inline-response-interface.ts+1 −1
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+1 −1
- Build/Sources/TypeScript/backend/tests/notification-test.ts+1 −1
- Build/Sources/TypeScript/backend/toolbar/system-information-menu.ts+1 −1
- Build/Sources/TypeScript/backend/viewport/content-container.ts+2 −2
- Build/Sources/TypeScript/backend/action-dispatcher.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+2 −2
- Build/Sources/TypeScript/backend/link-browser.ts+1 −1
- Build/Sources/TypeScript/backend/localization.ts+2 −3
- Build/Sources/TypeScript/backend/new-content-element-wizard-button.ts+3 −3
- Build/Sources/TypeScript/backend/online-media.ts+1 −2
- Build/Sources/TypeScript/backend/record-download-button.ts+3 −3
- Build/Sources/TypeScript/backend/svg-tree.ts+1 −0
Show 18 more files
- Build/Sources/TypeScript/core/event/event-interface.ts+1 −1
- Build/Sources/TypeScript/core/tests/ajax/ajax-request-test.ts+5 −2
- Build/Sources/TypeScript/install/module/environment/image-processing.ts+1 −1
- Build/.eslintrc.json+5 −4
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/event/trigger-request.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/password-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/link-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/online-media.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/record-download-button.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/image-processing.js+1 −1
Review log 1014
-
Benjamin Franzke uploaded patch set 1 08/10/23, 07:22
-
core-ci voted on patch set 1 V +1 08/10/23, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45309
-
Benjamin Franzke uploaded patch set 2
V +108/10/23, 08:29 -
Benjamin Franzke uploaded patch set 3 08/10/23, 08:30
-
core-ci voted on patch set 2 V +1 08/10/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45314
-
core-ci voted on patch set 3 V +1 08/10/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45315
-
Andreas Kienast commented on patch set 3 CR -1 08/10/23, 09:03
on it -
Benjamin Franzke commented on patch set 3 08/10/23, 09:12
trigger-request.ts:25Note for reviewers: "@typescript-eslint/no-this-alias" complained about this one, as that looked like this is referenced into a variable for usage in this-scoped-callbacks. Still ok to refactor this abit, IMO. -
Andreas Kienast uploaded patch set 4
CR -1V +108/10/23, 09:14 -
Andreas Kienast voted on patch set 4 V +1 CR +1 08/10/23, 09:15
-
core-ci voted on patch set 4 V +1 08/10/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45318
-
Benni Mack voted on patch set 4 V +1 CR +1 08/10/23, 10:42
-
Benjamin Franzke commented on patch set 4 V +2 CR +2 08/10/23, 11:20
Merging now. Also talked to Benji (who added all the linters), he is fine with disabling no-explicit-any for now (still, we should take of that later on, either with some kind of baseline - if possible - or by eslint-disable-comments). -
Benjamin Franzke merged patch set 5 08/10/23, 11:20