Review main Merged

80500[TASK] Eliminate eslint warnings

Benjamin Franzke CR +2 V +2 Hard +139 −147 updated 08/10/23, 11:20

Commit message

Also raise the fixed linters to error level in order
to not introduce similar errors again.

The linter @typescript-eslint/no-explicit-any is disabled for
now, in order for errors to be visible at first glance.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 38

Show 18 more files

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 08/10/23, 07:22

  2. core-ci voted on patch set 1 V +1 08/10/23, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45309

  3. Benjamin Franzke uploaded patch set 2 V +1 08/10/23, 08:29

  4. Benjamin Franzke uploaded patch set 3 08/10/23, 08:30

  5. core-ci voted on patch set 2 V +1 08/10/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45314

  6. core-ci voted on patch set 3 V +1 08/10/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45315

  7. Andreas Kienast commented on patch set 3 CR -1 08/10/23, 09:03

    on it
  8. Benjamin Franzke commented on patch set 3 08/10/23, 09:12

    trigger-request.ts:25

    Note for reviewers: "@typescript-eslint/no-this-alias" complained about this one, as that looked like this is referenced into a variable for usage in this-scoped-callbacks. Still ok to refactor this abit, IMO.
  9. Andreas Kienast uploaded patch set 4 CR -1 V +1 08/10/23, 09:14

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 08/10/23, 09:15

  11. core-ci voted on patch set 4 V +1 08/10/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45318

  12. Benni Mack voted on patch set 4 V +1 CR +1 08/10/23, 10:42

  13. Benjamin Franzke commented on patch set 4 V +2 CR +2 08/10/23, 11:20

    Merging now. Also talked to Benji (who added all the linters), he is fine with disabling no-explicit-any for now (still, we should take of that later on, either with some kind of baseline - if possible - or by eslint-disable-comments).
  14. Benjamin Franzke merged patch set 5 08/10/23, 11:20