Review 12.4 Merged

80502[TASK] Declare TypeScript types for global TYPO3 object

Benjamin Franzke CR +2 V +2 Normal +55 −38 updated 08/10/23, 09:22

Commit message

Missing declarations caused some method calls
and assignments to not be type checked, as all
members of the (top.|window.)TYPO3 object were
declared to `any`.
This actually revealed some invalid API usage.
which is fixed as a drive-by. (No real bugs were found,
as type checking in the APIs caught/ignored such cases)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 12

Review log 34

  1. Benjamin Franzke uploaded patch set 1 08/10/23, 09:09

  2. core-ci voted on patch set 1 V +1 08/10/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45317

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/10/23, 09:22

  4. Benjamin Franzke merged patch set 2 08/10/23, 09:22