Review main Merged

80506[TASK] Refactor EM InstallUtility

Christian Kuhn CR +2 V +2 Hard +92 −164 updated 08/10/23, 13:59

Commit message

Minor cleanup in extensionmanager FileHandlingUtility
to make a dependency more explicit, everything else is
within InstallUtility:

* No explicit singleton since this service is shared
  by default
* More injection over GU::makeInstance()
* Avoid extbase LocalizationUtility, use core
  LanguageService
* More strict types
* Inline a series of low-liner methods and
  protect more API to clean up class signature

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 08/10/23, 13:08

  2. core-ci voted on patch set 1 V +1 08/10/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45335

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/10/23, 13:50

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/10/23, 13:56

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/10/23, 13:57

  6. Christian Kuhn merged patch set 2 08/10/23, 13:57

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 08/10/23, 13:59