80510[TASK] Modernize ext:core ext_tables.sql DataType classes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 32
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/AbstractDataType.php2+23 −57
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BigIntDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BinaryDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BitDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BlobDataType.php+2 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/CharDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DateDataType.php+3 −7
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DateTimeDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DecimalDataType.php+2 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DoubleDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/EnumDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/FloatDataType.php+2 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/IntegerDataType.php+2 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/JsonDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/LongBlobDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/LongTextDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumBlobDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumIntDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumTextDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/NumericDataType.php+3 −1
Show 12 more files
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/RealDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/SetDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/SmallIntDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TextDataType.php+2 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TimeDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TimestampDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyBlobDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyIntDataType.php+3 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyTextDataType.php+3 −5
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/VarBinaryDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/VarCharDataType.php+3 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/YearDataType.php+3 −7
Review log 1315
-
Christian Kuhn uploaded patch set 1 08/10/23, 14:51
-
core-ci voted on patch set 1 V +1 08/10/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45343
-
Oliver Klee commented on patch set 1 08/10/23, 15:19
-
Christian Kuhn commented on patch set 1 08/10/23, 21:43
AbstractDataType.php:40Replyuh? we've done that in various other classes too - it's so much more dense. i'll follow here with this class, too. -
Stefan Bürk voted on patch set 1 V +1 CR +1 08/11/23, 06:46
-
Jörg Bösche voted on patch set 1 CR +1 08/11/23, 07:18
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 08/11/23, 07:56
-
Oliver Klee commented on patch set 1 CR -1 08/11/23, 08:01
-1 until Lolli and I have had a chance to have a chat about this. -
Christian Kuhn uploaded patch set 2
CR +1V +108/11/23, 09:05 -
Christian Kuhn commented on patch set 2 08/11/23, 09:06
Reply
Done -
Stefan Bürk voted on patch set 2 V +1 CR +1 08/11/23, 09:08
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 08/11/23, 09:10
-
core-ci voted on patch set 2 V +1 08/11/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45369
-
Christian Kuhn voted on patch set 2 V +2 CR +2 08/11/23, 09:14
-
Christian Kuhn merged patch set 3 08/11/23, 09:14
AbstractDataType.php:40