Review main Merged

80510[TASK] Modernize ext:core ext_tables.sql DataType classes

Christian Kuhn CR +2 V +2 Hard +111 −168 updated 08/11/23, 09:14

Commit message

Similar to #101642, the single DataType classes are
modernized towards better PHP types, are made
`@internal` and cleaned up a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 32

Show 12 more files

Review log 1315

  1. Christian Kuhn uploaded patch set 1 08/10/23, 14:51

  2. core-ci voted on patch set 1 V +1 08/10/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45343

  3. Oliver Klee commented on patch set 1 08/10/23, 15:19

    AbstractDataType.php:40

    Please let's use/keep the PHPDoc-style comments here: `/** */` instead of `//`. This way, IDEs will show the docs when hovering of a usage of the corresponding property.
  4. Christian Kuhn commented on patch set 1 08/10/23, 21:43

    AbstractDataType.php:40 Reply

    uh? we've done that in various other classes too - it's so much more dense. i'll follow here with this class, too.
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 08/11/23, 06:46

  6. Jörg Bösche voted on patch set 1 CR +1 08/11/23, 07:18

  7. Nikita Hovratov voted on patch set 1 V +1 CR +1 08/11/23, 07:56

  8. Oliver Klee commented on patch set 1 CR -1 08/11/23, 08:01

    -1 until Lolli and I have had a chance to have a chat about this.
  9. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/11/23, 09:05

  10. Christian Kuhn commented on patch set 2 08/11/23, 09:06

    Reply

    Done
  11. Stefan Bürk voted on patch set 2 V +1 CR +1 08/11/23, 09:08

  12. Nikita Hovratov voted on patch set 2 V +1 CR +1 08/11/23, 09:10

  13. core-ci voted on patch set 2 V +1 08/11/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45369

  14. Christian Kuhn voted on patch set 2 V +2 CR +2 08/11/23, 09:14

  15. Christian Kuhn merged patch set 3 08/11/23, 09:14