80512[BUGFIX] Fix undefined array key MPvar in PageSlugCandidateProvider
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 3338
Show 1013 earlier messages
-
Thomas Hohn uploaded patch set 1 08/10/23, 17:00
-
core-ci voted on patch set 1 V +1 08/10/23, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45348
-
Oliver Klee commented on patch set 1 08/10/23, 18:11
Have you checked if 11.5 is affected as well? -
Oliver Klee updated the commit message in patch set 2
V +108/10/23, 18:46 -
Oliver Klee commented on patch set 2 08/10/23, 18:47
Reply
Done - the code is the same in 11.5. -
core-ci voted on patch set 2 V +1 08/10/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45352
-
Thomas Hohn updated the commit message in patch set 3
V +108/13/23, 18:34 -
core-ci voted on patch set 3 V +1 08/13/23, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45457
-
Philipp Parzer voted on patch set 3 V +1 08/13/23, 20:30
-
Markus Klein commented on patch set 3 09/22/23, 08:47
PageSlugCandidateProvider.php:391are we sure $mountPointPage['MPvar'] is always set? -
Simon Schaufelberger commented on patch set 3 09/22/23, 09:08
I have tried to reproduce the bug but for me everything works and $pageCandidate['MPvar'] has a value. Can somebody verify this bug please? -
Oliver Klee commented on patch set 3 10/08/23, 13:23
How should we proceed here? -
Simon Schaufelberger commented on patch set 3 10/09/23, 18:31
Reply
you can try to reproduce the bug and see if this fix is actually needed.
-
Philipp Parzer voted on patch set 3 CR +1 10/10/23, 05:54
-
Thomas Hohn commented on patch set 3 10/10/23, 06:06
Reply
Apparently Phillip Parzer has verified that it fixes the issue -
Thomas Hohn commented on patch set 3 10/10/23, 06:56
Reply
Apparently Phillip Parzer has verified that it fixes the issuePageSlugCandidateProvider.php:391ReplyAs far as I could read the code where it's loaded -
Oliver Klee voted on patch set 3 V +1 CR +1 10/10/23, 07:45
-
Markus Klein voted on patch set 3 CR +1 10/12/23, 12:53
-
Benni Mack commented on patch set 3 12/05/23, 17:15
Still I'd like to know how to reproduce so we can actually fix the underlying cause somwheere in PageRepository -
Simon Schaufelberger commented on patch set 3 05/14/24, 11:50
Reply
Can you please provide an sql dump or something how I can verify this? -
Georg Ringer commented on patch set 3 CR +1 V +1 05/28/24, 21:25
PageSlugCandidateProvider.php:391ReplyI can reproduce it by changing the mount_pid_ol of one of the following pages to 1, see forge issue -
Stefan Bürk voted on patch set 3 CR -1 V -1 05/29/24, 09:00
-
Thomas Hohn commented on patch set 3 08/21/24, 11:02
Reply
Please ask @p.parzer@siwa.at - I only provided the proposed. There now seems to be a way to reproduce it -
Thomas Hohn commented on patch set 3 08/22/24, 04:36
Reply
@simonschaufi+typo3@gmail.com - there seems to be a description in the issue on how to reproduce it -
Thomas Hohn uploaded patch set 4
CR +1V +108/22/24, 04:38 -
core-ci voted on patch set 4 V +1 08/22/24, 04:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63950
-
Markus Klein voted on patch set 4 CR +1 08/22/24, 08:21
-
Simon Schaufelberger commented on patch set 4 08/22/24, 14:23
Reply
yes but I still can't reproduce it. -
Thomas Hohn commented on patch set 4 08/23/24, 06:14
Reply
Hi @georg.ringer@gmail.com - didn't you manage to reproduce it? -
Oliver Klee wrote 08/23/24, 08:15
Removed reviewer Oliver Klee. -
Philipp Parzer voted on patch set 4 CR +1 09/18/24, 05:52
-
Benni Mack updated the commit message in patch set 5
CR +1V +110/18/24, 13:53 -
Benni Mack rebased onto patch set 6 01/31/25, 12:02
-
core-ci voted on patch set 6 V +1 01/31/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73263
-
Benni Mack voted on patch set 6 CR +1 V +1 01/31/25, 12:53
-
Christian Kuhn commented on patch set 6 01/31/25, 13:05
Reply
georg answered in the issue he's able to reproduce. -
Christian Kuhn voted on patch set 6 CR +2 V +2 01/31/25, 13:05
-
Christian Kuhn merged patch set 7 01/31/25, 13:13