Review main Merged

80513[FEATURE] Auto-create DB fields from TCA columns for type "check"

Oliver Wand CR +2 V +2 Normal +60 −74 updated 09/09/23, 15:28

Commit message

Tables with TCA columns set to type="check" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one patch of more in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type="check".

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Wand +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 1524

  1. Oliver Wand uploaded patch set 1 08/10/23, 19:17

  2. Oliver Wand updated the commit message in patch set 2 08/10/23, 19:18

  3. core-ci voted on patch set 1 V -1 08/10/23, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45353

  4. core-ci voted on patch set 2 V -1 08/10/23, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45354

  5. Anja Leichsenring uploaded patch set 3 V -1 09/09/23, 08:25

  6. core-ci voted on patch set 3 V -1 09/09/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46415

  7. Anja Leichsenring uploaded patch set 4 V -1 09/09/23, 09:31

  8. core-ci voted on patch set 4 V -1 09/09/23, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46417

  9. Anja Leichsenring uploaded patch set 5 V -1 09/09/23, 10:54

  10. Anja Leichsenring uploaded patch set 6 09/09/23, 10:59

  11. core-ci voted on patch set 5 V -1 09/09/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46418

  12. core-ci voted on patch set 6 V +1 09/09/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46419

  13. Stefan Bürk updated the commit message in patch set 7 V +1 09/09/23, 13:14

  14. core-ci voted on patch set 7 V +1 09/09/23, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46420

  15. Oliver Wand commented on patch set 7 CR +1 09/09/23, 13:29

    Thanks Anja for finishing the patch! 😊
  16. Stefan Bürk commented on patch set 7 V +1 CR +1 09/09/23, 13:33

    Thanks Oliver for the initial work and thanks Anja for taking care of polishing and finishing it along with the ext:styleguide preparation.
  17. Oliver Wand rebased onto patch set 8 CR +1 V +1 09/09/23, 13:58

  18. core-ci voted on patch set 8 V +1 09/09/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46421

  19. Oliver Wand uploaded patch set 9 09/09/23, 14:20

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  20. core-ci voted on patch set 9 V +1 09/09/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46424

  21. Oliver Wand voted on patch set 9 CR +1 09/09/23, 14:36

  22. Stefan Bürk voted on patch set 9 V +1 CR +1 09/09/23, 15:23

  23. Anja Leichsenring voted on patch set 9 V +2 CR +2 09/09/23, 15:28

  24. Anja Leichsenring merged patch set 10 09/09/23, 15:28