Review main Merged

80515[FEATURE] Auto-create DB fields from TCA for type "email"

Oliver Wand CR +2 V +2 Normal +97 −41 updated 08/30/23, 11:33

Commit message

Tables with TCA columns set to type="email" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one patch of more in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=email.

According tests sets are added and existing tests
are hardened a bit towards more strict comparison.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 2335

Show 610 earlier messages
  1. Oliver Wand uploaded patch set 1 08/10/23, 19:48

  2. core-ci voted on patch set 1 V -1 08/10/23, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45357

  3. Anja Leichsenring uploaded patch set 2 V -1 08/25/23, 09:01

  4. core-ci voted on patch set 2 V -1 08/25/23, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45822

  5. Anja Leichsenring uploaded patch set 3 V -1 08/25/23, 09:21

  6. core-ci voted on patch set 3 V +1 08/25/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45823

  7. Oliver Klee commented on patch set 3 CR -1 08/25/23, 09:44

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:63

    This looks like an unresolved merge conflict.
  8. Anja Leichsenring updated the commit message in patch set 4 CR -1 V +1 08/25/23, 09:52

  9. Anja Leichsenring commented on patch set 5 08/25/23, 09:53

    Published edit on patch set 4.
  10. core-ci voted on patch set 4 V +1 08/25/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45824

  1. Anja Leichsenring commented on patch set 5 08/25/23, 10:05

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:63 Reply

    Done
  2. core-ci voted on patch set 5 V +1 08/25/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45825

  3. Anja Leichsenring commented on patch set 6 V +1 08/25/23, 10:28

    Published edit on patch set 5.
  4. core-ci voted on patch set 6 V -1 08/25/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45826

  5. Anja Leichsenring commented on patch set 7 V -1 08/25/23, 11:06

    Published edit on patch set 6.
  6. core-ci voted on patch set 7 V +1 08/25/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45827

  7. Jörg Bösche voted on patch set 7 CR +1 08/25/23, 13:39

  8. Christian Kuhn commented on patch set 7 08/29/23, 20:11

    tx_blogexample_domain_model_comment.php:54

    good catch. eval=trim is obsolete with type=email, is it?

    tx_blogexample_domain_model_comment.php:55

    and max can be ditched, too, i suppose.

    tx_blogexample_domain_model_person.php:80

    same remarks as in the other blog_example tca file.
  9. Christian Kuhn commented on patch set 7 08/29/23, 22:22

    tx_blogexample_domain_model_comment.php:54 Reply

    Done

    tx_blogexample_domain_model_comment.php:55 Reply

    Done

    tx_blogexample_domain_model_person.php:80 Reply

    Done
  10. Christian Kuhn uploaded patch set 8 CR +1 V +1 08/29/23, 22:28

  11. core-ci voted on patch set 8 V +1 08/29/23, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45999

  12. Stefan Bürk uploaded patch set 9 V +1 08/29/23, 22:38

  13. core-ci voted on patch set 9 V -1 08/29/23, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46000

  14. Christian Kuhn uploaded patch set 10 V -1 08/29/23, 22:51

  15. Christian Kuhn updated the commit message in patch set 11 08/29/23, 22:52

  16. Christian Kuhn updated the commit message in patch set 12 08/29/23, 22:52

  17. core-ci voted on patch set 12 V +1 08/29/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46003

  18. core-ci voted on patch set 10 V +1 08/29/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46001

  19. core-ci voted on patch set 11 V +1 08/29/23, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46002

  20. Christian Kuhn voted on patch set 12 V +1 CR +1 08/29/23, 23:08

  21. Stefan Bürk voted on patch set 12 CR +1 08/29/23, 23:11

  22. Stefan Bürk voted on patch set 12 V +1 08/29/23, 23:11

  23. Anja Leichsenring voted on patch set 12 V +1 CR +1 08/30/23, 11:31

  24. Christian Kuhn voted on patch set 12 V +2 CR +2 08/30/23, 11:33

  25. Christian Kuhn merged patch set 13 08/30/23, 11:33