80515[FEATURE] Auto-create DB fields from TCA for type "email"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+19 −4
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101553-Auto-createDBFieldsFromTCAColumns.rst2+1 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+75 −26
- typo3/sysext/core/ext_tables.sql+0 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_comment.php4+1 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php2+1 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql+0 −2
- typo3/sysext/frontend/ext_tables.sql+0 −1
Review log 2335
Show 610 earlier messages
-
Oliver Wand uploaded patch set 1 08/10/23, 19:48
-
core-ci voted on patch set 1 V -1 08/10/23, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45357
-
Anja Leichsenring uploaded patch set 2
V -108/25/23, 09:01 -
core-ci voted on patch set 2 V -1 08/25/23, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45822
-
Anja Leichsenring uploaded patch set 3
V -108/25/23, 09:21 -
core-ci voted on patch set 3 V +1 08/25/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45823
-
Oliver Klee commented on patch set 3 CR -1 08/25/23, 09:44
-
Anja Leichsenring updated the commit message in patch set 4
CR -1V +108/25/23, 09:52 -
Anja Leichsenring commented on patch set 5 08/25/23, 09:53
Published edit on patch set 4. -
core-ci voted on patch set 4 V +1 08/25/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45824
-
Anja Leichsenring commented on patch set 5 08/25/23, 10:05
Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:63ReplyDone -
core-ci voted on patch set 5 V +1 08/25/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45825
-
Anja Leichsenring commented on patch set 6
V +108/25/23, 10:28Published edit on patch set 5. -
core-ci voted on patch set 6 V -1 08/25/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45826
-
Anja Leichsenring commented on patch set 7
V -108/25/23, 11:06Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 08/25/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45827
-
Jörg Bösche voted on patch set 7 CR +1 08/25/23, 13:39
-
Christian Kuhn commented on patch set 7 08/29/23, 20:11
tx_blogexample_domain_model_comment.php:54good catch. eval=trim is obsolete with type=email, is it?tx_blogexample_domain_model_comment.php:55and max can be ditched, too, i suppose.tx_blogexample_domain_model_person.php:80same remarks as in the other blog_example tca file. -
Christian Kuhn commented on patch set 7 08/29/23, 22:22
tx_blogexample_domain_model_comment.php:54ReplyDonetx_blogexample_domain_model_comment.php:55ReplyDonetx_blogexample_domain_model_person.php:80ReplyDone -
Christian Kuhn uploaded patch set 8
CR +1V +108/29/23, 22:28 -
core-ci voted on patch set 8 V +1 08/29/23, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45999
-
Stefan Bürk uploaded patch set 9
V +108/29/23, 22:38 -
core-ci voted on patch set 9 V -1 08/29/23, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46000
-
Christian Kuhn uploaded patch set 10
V -108/29/23, 22:51 -
Christian Kuhn updated the commit message in patch set 11 08/29/23, 22:52
-
Christian Kuhn updated the commit message in patch set 12 08/29/23, 22:52
-
core-ci voted on patch set 12 V +1 08/29/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46003
-
core-ci voted on patch set 10 V +1 08/29/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46001
-
core-ci voted on patch set 11 V +1 08/29/23, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46002
-
Christian Kuhn voted on patch set 12 V +1 CR +1 08/29/23, 23:08
-
Stefan Bürk voted on patch set 12 CR +1 08/29/23, 23:11
-
Stefan Bürk voted on patch set 12 V +1 08/29/23, 23:11
-
Anja Leichsenring voted on patch set 12 V +1 CR +1 08/30/23, 11:31
-
Christian Kuhn voted on patch set 12 V +2 CR +2 08/30/23, 11:33
-
Christian Kuhn merged patch set 13 08/30/23, 11:33
Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:63