Review main Merged

80516[TASK] Remove jQuery from Install Tool modules

Andreas Nedbal CR +2 V +2 Nightmare +1730 −1268 updated 08/28/23, 08:05

Commit message

This patch removes the jQuery usages from all Install Tool modules.
It's done in one go because of the dependency of the modules on a
abstract class that provides methods returning jQuery objects.

The miration of the installer (the module that performs
the initial setup) is left for another patch, as it is
basically a distinct tool and out of scope for this patch.
Also the jquery-based chosen-js library will be replaced separately.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 69

Show 49 more files

Review log 3255

Show 1530 earlier messages
  1. Andreas Nedbal uploaded patch set 1 08/10/23, 23:01

  2. core-ci voted on patch set 1 V -1 08/10/23, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45359

  3. Andreas Nedbal uploaded patch set 2 V -1 08/12/23, 03:41

  4. core-ci voted on patch set 2 V -1 08/12/23, 03:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45404

  5. Andreas Nedbal uploaded patch set 3 V -1 08/12/23, 21:25

  6. core-ci voted on patch set 3 V -1 08/12/23, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45427

  7. Andreas Nedbal uploaded patch set 4 V -1 08/12/23, 22:56

  8. core-ci voted on patch set 4 V -1 08/12/23, 23:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45428

  9. Andreas Nedbal uploaded patch set 5 V -1 08/12/23, 23:04

  10. core-ci voted on patch set 5 V -1 08/12/23, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45429

  11. Andreas Nedbal uploaded patch set 6 V -1 08/13/23, 02:33

  12. Andreas Nedbal uploaded patch set 7 08/13/23, 02:34

  13. core-ci voted on patch set 6 V -1 08/13/23, 02:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45432

  14. core-ci voted on patch set 7 V -1 08/13/23, 02:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45433

  15. Andreas Nedbal uploaded patch set 8 V -1 08/13/23, 04:08

  16. core-ci voted on patch set 8 V -1 08/13/23, 04:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45435

  17. Andreas Nedbal uploaded patch set 9 V -1 08/13/23, 04:21

  18. core-ci voted on patch set 9 V -1 08/13/23, 04:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45436

  19. Andreas Nedbal uploaded patch set 10 V -1 08/13/23, 04:46

  20. Andreas Nedbal uploaded patch set 11 08/13/23, 04:52

  21. core-ci voted on patch set 10 V -1 08/13/23, 04:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45437

  22. core-ci voted on patch set 11 V -1 08/13/23, 05:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45438

  23. Andreas Nedbal uploaded patch set 12 V -1 08/13/23, 14:55

  24. core-ci voted on patch set 12 V -1 08/13/23, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45447

  25. Andreas Nedbal uploaded patch set 13 V -1 08/13/23, 15:34

  26. core-ci voted on patch set 13 V -1 08/13/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45451

  27. Andreas Nedbal uploaded patch set 14 V -1 08/13/23, 16:38

  28. core-ci voted on patch set 14 V -1 08/13/23, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45453

  29. Andreas Nedbal uploaded patch set 15 V -1 08/15/23, 13:23

  30. core-ci voted on patch set 15 V -1 08/15/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45505

  1. Andreas Kienast commented on patch set 15 CR -2 08/23/23, 08:57

    on it
  2. Andreas Kienast uploaded patch set 16 V -1 08/23/23, 14:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  3. core-ci voted on patch set 16 V -1 08/23/23, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45751

  4. Benjamin Franzke uploaded patch set 17 V -1 08/25/23, 11:59

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  5. core-ci voted on patch set 17 V -1 08/25/23, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45828

  6. Benjamin Franzke uploaded patch set 18 V -1 08/25/23, 12:43

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  7. core-ci voted on patch set 18 V -1 08/25/23, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45830

  8. Benjamin Franzke uploaded patch set 19 V -1 08/25/23, 14:31

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  9. core-ci voted on patch set 19 V -1 08/25/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45833

  10. Benjamin Franzke uploaded patch set 20 V -1 08/25/23, 17:09

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  11. Benjamin Franzke uploaded patch set 21 08/25/23, 17:11

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  12. core-ci voted on patch set 21 V -1 08/25/23, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45837

  13. Benjamin Franzke uploaded patch set 22 V -1 08/25/23, 17:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  14. core-ci voted on patch set 22 V +1 08/25/23, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45838

  15. Benjamin Franzke commented on patch set 22 CR -1 08/26/23, 08:45

    upgrade-docs.ts:212

    Needs to use $(this.chosenField).val() for now, since the value-array is not exposed to the HTMLElement `value` property. Or is there another workaround?
  16. Benjamin Franzke uploaded patch set 23 CR -1 V +1 08/26/23, 13:58

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  17. Benjamin Franzke commented on patch set 23 08/26/23, 13:58

    upgrade-docs.ts:212 Reply

    Done
  18. core-ci voted on patch set 23 V +1 08/26/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45857

  19. Andreas Kienast voted on patch set 23 CR 0 08/28/23, 05:53

  20. Andreas Kienast commented on patch set 23 08/28/23, 07:24

    local-configuration.ts:66

    This is currently broken, the modal catches the Escape key and closes itself instead. Can be solved in a different patch, tho.

    offset-group.ts:9

    Can be `protected`.

    offset-group.ts:14

    Can be `protected`.

    wrap-group.ts:9

    Can be `protected`.

    wrap-group.ts:14

    Can be `protected`.
  21. Andreas Kienast uploaded patch set 24 CR +1 V +1 08/28/23, 07:36

  22. core-ci voted on patch set 24 V +1 08/28/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45872

  23. Andreas Kienast commented on patch set 24 V +1 CR +1 08/28/23, 08:02

    local-configuration.ts:66 Reply

    Done

    offset-group.ts:9 Reply

    Done

    offset-group.ts:14 Reply

    Done

    wrap-group.ts:9 Reply

    Done

    wrap-group.ts:14 Reply

    Done
  24. Benjamin Franzke voted on patch set 24 V +2 CR +2 08/28/23, 08:05

  25. Benjamin Franzke merged patch set 25 08/28/23, 08:05