80518[BUGFIX] Ensure copied records keep l10n_state behavior
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php3+2 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+1 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeNModifyNCopyPageWSynchronization.csvnew+37 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+12 −0
Review log 1823
-
Benni Mack uploaded patch set 1 08/11/23, 08:58
-
Benni Mack updated the commit message in patch set 2 08/11/23, 08:58
-
core-ci voted on patch set 1 V +1 08/11/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45367
-
core-ci voted on patch set 2 V +1 08/11/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45368
-
Benni Mack uploaded patch set 3
V +108/11/23, 10:53 -
Benni Mack voted on patch set 3 CR +1 08/11/23, 10:58
-
Benni Mack voted on patch set 3 CR 0 08/11/23, 10:58
-
Benni Mack wrote 08/11/23, 10:58
Topic set to DataHandler -
core-ci voted on patch set 3 V +1 08/11/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45378
-
Oliver Klee commented on patch set 3 08/11/23, 12:17
DataMapItem.php:222Now that we have three comparisons, an `in_array` might be called for: `if (!in_array($this->source, [0, null, $this->parent], true)) {` -
Benni Mack updated the commit message in patch set 4
V +108/11/23, 20:59 -
core-ci voted on patch set 4 V +1 08/11/23, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45397
-
Christian Kuhn commented on patch set 4 08/14/23, 10:17
DataMapItem.php:222Replyi'd prefer to keep as proposed: the combined boolean expressions are easier to grasp. -
Oliver Klee commented on patch set 4 08/14/23, 10:18
DataMapItem.php:222ReplyAck -
Christian Kuhn uploaded patch set 5
V +108/14/23, 10:30 -
Christian Kuhn voted on patch set 5 V +1 CR +1 08/14/23, 10:31
-
core-ci voted on patch set 5 V +1 08/14/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45475
-
Oliver Klee voted on patch set 5 V +1 08/14/23, 16:39
-
Jörg Bösche voted on patch set 5 CR +1 08/14/23, 19:05
-
Andreas Kienast voted on patch set 5 V +1 CR +1 08/15/23, 12:10
-
Stefan Bürk commented on patch set 5 V +1 CR +1 08/15/23, 13:25
DataHandler.php:3749Is this sentence complete ? -
Stefan Bürk commented on patch set 5 V +2 CR +2 08/15/23, 13:46
DataHandler.php:3749ReplyDone -
Stefan Bürk merged patch set 6 08/15/23, 14:05