Review main Merged

80519[TASK] Clean up ext_tables.sql parser

Christian Kuhn CR +2 V +2 Hard +137 −279 updated 08/11/23, 13:38

Commit message

* Parser is now a stateless service
* Declare final, more private methods
* Remove unused methods
* More type hints and other improvements

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1519

  1. Christian Kuhn uploaded patch set 1 08/11/23, 09:28

  2. core-ci voted on patch set 1 V +1 08/11/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45372

  3. Oliver Klee commented on patch set 1 08/11/23, 10:12

    Parser.php:91

    `@return list<Table>`
  4. Christian Kuhn uploaded patch set 2 V +1 08/11/23, 10:41

  5. Christian Kuhn uploaded patch set 3 08/11/23, 10:42

  6. Christian Kuhn commented on patch set 1 08/11/23, 10:42

    Parser.php:91 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/11/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45376

  8. core-ci voted on patch set 3 V +1 08/11/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45377

  9. Oliver Klee voted on patch set 3 V +1 08/11/23, 12:11

  10. Oliver Klee commented on patch set 3 08/11/23, 12:15

    Looks very good all in all! I've added a comment for a place where we can improve the usage of variables.

    Parser.php:119

    I'd prefer we used two different names here: One for the parameter, and one for the statement created with `createStatement` (as both are different variables for different purposes).
  11. Christian Kuhn uploaded patch set 4 V +1 08/11/23, 12:47

  12. Christian Kuhn commented on patch set 3 08/11/23, 12:47

    Parser.php:119 Reply

    Done
  13. Jörg Bösche voted on patch set 4 CR +1 08/11/23, 12:51

  14. Oliver Klee voted on patch set 4 V +1 CR +1 08/11/23, 12:52

  15. core-ci voted on patch set 4 V +1 08/11/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45385

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/11/23, 13:04

  17. Andreas Kienast voted on patch set 4 CR +1 08/11/23, 13:13

  18. Anja Leichsenring voted on patch set 4 V +2 CR +2 08/11/23, 13:38

  19. Anja Leichsenring merged patch set 5 08/11/23, 13:38