80519[TASK] Clean up ext_tables.sql parser
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 17
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Database/Schema/Exception/StatementException.php+7 −7
- typo3/sysext/core/Classes/Database/Schema/Parser/Lexer.php+0 −10
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php4+90 −222
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+4 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/BinaryDataTypeTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/CharDataTypeTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/AbstractDataTypeBaseTestCase.php+5 −11
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionAttributesTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionItemTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/CreateTableFragmentTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ForeignKeyDefinitionTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/IndexDefinitionTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ReferenceDefinitionTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableOptionsTest.php+3 −2
Review log 1519
-
Christian Kuhn uploaded patch set 1 08/11/23, 09:28
-
core-ci voted on patch set 1 V +1 08/11/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45372
-
Oliver Klee commented on patch set 1 08/11/23, 10:12
-
Christian Kuhn uploaded patch set 2
V +108/11/23, 10:41 -
Christian Kuhn uploaded patch set 3 08/11/23, 10:42
-
Christian Kuhn commented on patch set 1 08/11/23, 10:42
Parser.php:91ReplyDone -
core-ci voted on patch set 2 V +1 08/11/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45376
-
core-ci voted on patch set 3 V +1 08/11/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45377
-
Oliver Klee voted on patch set 3 V +1 08/11/23, 12:11
-
Oliver Klee commented on patch set 3 08/11/23, 12:15
Looks very good all in all! I've added a comment for a place where we can improve the usage of variables.Parser.php:119I'd prefer we used two different names here: One for the parameter, and one for the statement created with `createStatement` (as both are different variables for different purposes). -
Christian Kuhn uploaded patch set 4
V +108/11/23, 12:47 -
Christian Kuhn commented on patch set 3 08/11/23, 12:47
Parser.php:119ReplyDone -
Jörg Bösche voted on patch set 4 CR +1 08/11/23, 12:51
-
Oliver Klee voted on patch set 4 V +1 CR +1 08/11/23, 12:52
-
core-ci voted on patch set 4 V +1 08/11/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45385
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 08/11/23, 13:04
-
Andreas Kienast voted on patch set 4 CR +1 08/11/23, 13:13
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 08/11/23, 13:38
-
Anja Leichsenring merged patch set 5 08/11/23, 13:38
Parser.php:91