Review main Merged

80522[TASK] Migrate `getMockForAbstractClass()` calls in `EXT:form`

Oliver Klee CR +2 V +2 Hard +170 −232 updated 08/28/23, 09:25

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow best practices and
avoid deprecation warnings later with PHPUnit 11.

We do this by creating dedicated fixture subclasses of the affected
abstract classes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1318

  1. Oliver Klee uploaded patch set 1 08/11/23, 12:52

  2. core-ci voted on patch set 1 V +1 08/11/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45386

  3. Oliver Klee uploaded patch set 2 V +1 08/16/23, 11:52

  4. Oliver Klee wrote 08/16/23, 11:53

    Topic set to phpunit
  5. core-ci voted on patch set 2 V +1 08/16/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45552

  6. Christian Kuhn commented on patch set 2 08/23/23, 19:01

    what's wip here? could we get this done?
  7. Oliver Klee commented on patch set 2 08/23/23, 19:26

    Reply

    There are still more calls I’d like to remove, and before that, I’d like to get this change merged in order to reduce the number of open non-WIP changes by me: 80247: [!!!][TASK] Add native type declarations to GU array methods | https://review.typo3.org/c/Packages/TYPO3.CMS/+/80247
  8. Oliver Klee uploaded patch set 3 V +1 08/24/23, 18:06

  9. Oliver Klee commented on patch set 3 08/24/23, 18:06

    Reply

    Done, and ready for review. :-)
  10. Oliver Klee uploaded patch set 4 08/24/23, 18:07

  11. core-ci voted on patch set 3 V +1 08/24/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45794

  12. core-ci voted on patch set 4 V +1 08/24/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45795

  13. Oliver Klee rebased onto patch set 5 V +1 08/28/23, 08:12

  14. core-ci voted on patch set 5 V +1 08/28/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45876

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 08/28/23, 09:18

  16. Stefan Bürk voted on patch set 5 V +1 CR +1 08/28/23, 09:20

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 08/28/23, 09:25

  18. Christian Kuhn merged patch set 6 08/28/23, 09:25