80522[TASK] Migrate `getMockForAbstractClass()` calls in `EXT:form`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/form/Tests/Unit/Domain/FormElements/Fixtures/TestingFormElement.phpnew+31 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/Fixtures/TestingSection.phpnew+37 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+42 −132
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+11 −78
- typo3/sysext/form/Tests/Unit/Domain/Renderable/Fixtures/TestingRenderable.phpnew+27 −0
- typo3/sysext/form/Tests/Unit/Domain/Renderable/AbstractRenderableTest.php+22 −22
Review log 1318
-
Oliver Klee uploaded patch set 1 08/11/23, 12:52
-
core-ci voted on patch set 1 V +1 08/11/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45386
-
Oliver Klee uploaded patch set 2
V +108/16/23, 11:52 -
Oliver Klee wrote 08/16/23, 11:53
Topic set to phpunit -
core-ci voted on patch set 2 V +1 08/16/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45552
-
Christian Kuhn commented on patch set 2 08/23/23, 19:01
what's wip here? could we get this done? -
Oliver Klee commented on patch set 2 08/23/23, 19:26
Reply
There are still more calls I’d like to remove, and before that, I’d like to get this change merged in order to reduce the number of open non-WIP changes by me: 80247: [!!!][TASK] Add native type declarations to GU array methods | https://review.typo3.org/c/Packages/TYPO3.CMS/+/80247 -
Oliver Klee uploaded patch set 3
V +108/24/23, 18:06 -
Oliver Klee commented on patch set 3 08/24/23, 18:06
Reply
Done, and ready for review. :-) -
Oliver Klee uploaded patch set 4 08/24/23, 18:07
-
core-ci voted on patch set 3 V +1 08/24/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45794
-
core-ci voted on patch set 4 V +1 08/24/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45795
-
Oliver Klee rebased onto patch set 5
V +108/28/23, 08:12 -
core-ci voted on patch set 5 V +1 08/28/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45876
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/28/23, 09:18
-
Stefan Bürk voted on patch set 5 V +1 CR +1 08/28/23, 09:20
-
Christian Kuhn voted on patch set 5 V +2 CR +2 08/28/23, 09:25
-
Christian Kuhn merged patch set 6 08/28/23, 09:25