Review main Merged

80524[TASK] Always reset singleton instances for whole testcases

Oliver Klee CR +2 V +2 Easy +11 −16 updated 08/11/23, 19:58

Commit message

For (unit) tests that use singletons, the singletone instances should
always be reset for all tests from the corresponding testcase, not
only for individual tests.

This reduces the risk of new tests missing the singleton reset.
Also, it makes the code a bit shorter.

Also drop one instance of setting `$this->resetSingletonInstances`
where the property already was set to `true`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Oliver Klee uploaded patch set 1 08/11/23, 13:58

  2. core-ci voted on patch set 1 V +1 08/11/23, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45390

  3. Oliver Klee commented on patch set 1 08/11/23, 14:11

    How to verify: Check that CI is green.
  4. Oliver Klee commented on patch set 1 08/11/23, 14:15

    AbstractSectionTest.php:178

    Note: This is said place where the property was already set to `true`.
  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/11/23, 19:58

  6. Christian Kuhn merged patch set 2 08/11/23, 19:58