Review main Merged

80526[TASK] Migrate `getMockForAbstractClass()` calls in `EXT:core`

Oliver Klee CR +2 V +2 Easy +36 −3 updated 08/16/23, 09:29

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow best practices and
avoid deprecation warnings later with PHPUnit 11.

We do this by creating dedicated fixture subclasses of the affected
abstract classes.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 812

  1. Oliver Klee uploaded patch set 1 08/11/23, 14:10

  2. core-ci voted on patch set 1 V +1 08/11/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45392

  3. Oliver Klee rebased onto patch set 2 V +1 08/14/23, 16:38

  4. core-ci voted on patch set 2 V +1 08/14/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45485

  5. Oliver Klee wrote 08/14/23, 18:14

    Topic set to phpunit
  6. Stefan Bürk updated the commit message in patch set 3 V +1 08/15/23, 09:43

  7. Stefan Bürk updated the commit message in patch set 4 08/15/23, 09:43

  8. Stefan Bürk voted on patch set 4 V +1 CR +1 08/15/23, 09:44

  9. core-ci voted on patch set 3 V +1 08/15/23, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45499

  10. core-ci voted on patch set 4 V +1 08/15/23, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45500

  11. Nikita Hovratov voted on patch set 4 V +2 CR +2 08/16/23, 09:28

  12. Nikita Hovratov merged patch set 5 08/16/23, 09:29