Review main Merged

80528[BUGFIX] Fix link attribute handling in ckeditor

Sybille Peters CR +2 V +2 Easy +5 −1 updated 08/17/23, 21:57

Commit message

Fix handling link attributes (such as target, title)
in link browser. The attributes were formerly not
always applied to the link currently being edited.

The problem appeared to be that the current selection
in the editor lost focus and when link attributes
were handled for this case, only the href attribute
was applied.

This is a follow-up patch for patch
https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034
which did not fully resolve problems with setting the
link attributes.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 68

  1. Sybille Peters uploaded patch set 1 08/12/23, 08:26

  2. core-ci voted on patch set 1 V +1 08/12/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45405

  3. Sybille Peters wrote 08/13/23, 10:08

    Topic set to rte_ckeditor
  4. Sybille Peters updated the commit message in patch set 2 V +1 08/13/23, 20:29

  5. core-ci voted on patch set 2 V +1 08/13/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45458

  6. Benjamin Franzke voted on patch set 2 V +1 CR +1 08/16/23, 09:05

  7. Andreas Nedbal voted on patch set 2 V +2 CR +2 08/17/23, 21:56

  8. Andreas Nedbal merged patch set 3 08/17/23, 21:57