Review main Merged

80539[BUGFIX] Fix Linkvalidator checks on hidden pages

Sybille Peters CR +2 V +2 Normal +60 −9 updated 08/23/23, 17:35

Commit message

The following problems are now fixed:

1. do not check links on hidden pages (if checkhidden=0)
2. show links on hidden pages (if checkhidden=1)

Also, unit tests are introduced for PagesRepository.
More functional tests can be added in additional patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Sybille Peters uploaded patch set 1 08/13/23, 08:12

  2. Sybille Peters wrote 08/13/23, 08:14

    Topic set to linkvalidator
  3. core-ci voted on patch set 1 V +1 08/13/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45441

  4. Nikita Hovratov uploaded patch set 2 V +1 08/19/23, 11:08

  5. core-ci voted on patch set 2 V +1 08/19/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45616

  6. Oliver Klee voted on patch set 2 V +1 08/21/23, 11:56

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/23/23, 15:52

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 08/23/23, 16:00

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/23/23, 17:35

  10. Christian Kuhn merged patch set 3 08/23/23, 17:35