80540[!!!][TASK] Disable external links by default in Linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Chris Müller +1
-
Verified V +2 Done
- Benni Mack +2
- Chris Müller +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst5new+89 −0
- typo3/sysext/core/Documentation/Settings.cfg+1 −0
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+6 −1
- typo3/sysext/linkvalidator/Configuration/page.tsconfig+3 −1
- typo3/sysext/linkvalidator/Documentation/Configuration/Index.rst2+4 −1
Review log 1216
-
Sybille Peters uploaded patch set 1 08/13/23, 11:43
-
Sybille Peters wrote 08/13/23, 11:43
Topic set to linkvalidator -
core-ci voted on patch set 1 V +1 08/13/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45445
-
Chris Müller commented on patch set 1 CR -1 08/13/23, 11:57
Breaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst:45I suggest to add an example, on how to activate it again to ease the reactivation, like mod.linkvalidator.linktypes = db,file,externalBreaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst:63So, we are suggesting solutions for the user, but do not want to implement them? That's fine for me, but maybe we can add a sentence: "If you have a solution for one of the topics, please also consider to contribute it to the linkvalidator system extension by providing a patch."Index.rst:132Please add a ".. versionchanged:: 13.0" directive with an appropriate text which informs the user about this change also in this docs. -
Sybille Peters commented on patch set 1 08/13/23, 12:58
Breaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst:63Reply> So, we are suggesting solutions for the user, but do not want to implement them? You are welcome to submit patches ;-) But seriously, it is not so easy to fix, it will take time until fixed in core and some things not so easy to handle on a general level and should be customized. For example, imagine the site has 100000 external links with unique links targets and more than 10000 links are for a single site and these are checked every day per scheduler. Here is the question if this should really happen (e.g. submitting so many requests to the site). On the other hand a site might have only a few external links or link checking, no false positives and it is not a problem. What I find problematic is excessive requests to external sites. This should not happen by default. If someone wishes to disregard warnings that is their responsibility, but I would like to relieve core linkvalidator from this responsibility. In most cases there is the necessity for the administrator to think this through and we can't make (all) these decisions for them. See also wordpress solution which provides a "cloud based link checker". Something like this might be a long term solution. https://wordpress.org/plugins/broken-link-checker/ I am trying to find short term solutions (which are admittedly not perfect but possible with the limited personpower available). Long term solutions are also being considered. Will address other comments and push patch later, thanks for the review :) -
Chris Müller commented on patch set 1 08/13/23, 13:52
Breaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst:63ReplyI see. I haven't dealt with such large sites. So we may need something like an asynchronous queue with a kind of grouping per domain/site, maybe the newly introduced message bus is something we can use for it: 1. dispatch a message: store an external link to be checked 2. consume the messages (make the real request to external site). But haven't worked with the messenger yet. So, go ahead with this patch and thanks for your dedicated work to the linkvalidator :-) -
Sybille Peters uploaded patch set 2
CR -1V +108/13/23, 14:36 -
Sybille Peters commented on patch set 1 08/13/23, 14:36
Breaking-101671-DisableExternalLinktypesByDefaultInEXTlinkvalidator.rst:45ReplyDoneIndex.rst:132ReplyDone -
core-ci voted on patch set 2 V +1 08/13/23, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45446
-
Chris Müller updated the commit message in patch set 3
V +108/13/23, 15:23 -
core-ci voted on patch set 3 V +1 08/13/23, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45450
-
Chris Müller uploaded patch set 4
V +108/13/23, 16:59 -
Chris Müller voted on patch set 4 V +1 CR +1 08/13/23, 17:00
-
core-ci voted on patch set 4 V +1 08/13/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45455
-
Benni Mack voted on patch set 4 V +2 CR +2 08/13/23, 18:50
-
Benni Mack merged patch set 5 08/13/23, 18:50