80542[TASK] Improve linktypes checkboxes UI for Linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Sybille Peters uploaded patch set 1 08/13/23, 16:41
-
Sybille Peters wrote 08/13/23, 16:42
Topic set to linkvalidator -
core-ci voted on patch set 1 V +1 08/13/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45454
-
Torben Hansen commented on patch set 1 08/19/23, 10:18
CheckOptions.html:16I prefer to use a language label instead of a hardcoded text here.CheckOptions.html:17I prefer to use a language label instead of a hardcoded text here. -
Sybille Peters uploaded patch set 2
V +108/19/23, 11:27 -
Sybille Peters commented on patch set 2 08/19/23, 11:28
CheckOptions.html:16ReplyDoneCheckOptions.html:17ReplyDone -
core-ci voted on patch set 2 V +1 08/19/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45617
-
Torben Hansen commented on patch set 2 08/26/23, 11:23
I think we also need to react on changes to the individual checkboxes - e.g., when I use the new "Toggle all" checkbox and then manually unselect one of the checked checkboxes, the ""Toggle all" checkbox remains checked. Or when you manually select all checkboxes, the "Toogle all" checkbox should automatically be checked. As an example, see the "selectCheckBox" FormEngine component. -
Sybille Peters commented on patch set 2 CR -1 08/29/23, 05:33
Make change as suggested by Torben. Also, maybe look into providing a generic solution as ViewHelper. -
Sybille Peters uploaded patch set 3
CR -1V +109/16/23, 16:24 -
core-ci voted on patch set 3 V +1 09/16/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46625
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/18/23, 14:19
-
Stefan Bürk voted on patch set 3 V +2 CR +2 09/18/23, 15:09
-
Stefan Bürk merged patch set 4 09/18/23, 15:09