Review main Merged

80542[TASK] Improve linktypes checkboxes UI for Linkvalidator

Sybille Peters CR +2 V +2 Normal +49 −7 updated 09/18/23, 15:09

Commit message

Improve selection of Linkvalidator linkypes checkboxes form
by adding a "Toggle all" checkbox as is already used in
FormEngine `selectCheckBox` renderType.

This improves the usability of the form and makes multiple
clicks unnecessary.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Sybille Peters uploaded patch set 1 08/13/23, 16:41

  2. Sybille Peters wrote 08/13/23, 16:42

    Topic set to linkvalidator
  3. core-ci voted on patch set 1 V +1 08/13/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45454

  4. Torben Hansen commented on patch set 1 08/19/23, 10:18

    CheckOptions.html:16

    I prefer to use a language label instead of a hardcoded text here.

    CheckOptions.html:17

    I prefer to use a language label instead of a hardcoded text here.
  5. Sybille Peters uploaded patch set 2 V +1 08/19/23, 11:27

  6. Sybille Peters commented on patch set 2 08/19/23, 11:28

    CheckOptions.html:16 Reply

    Done

    CheckOptions.html:17 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/19/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45617

  8. Torben Hansen commented on patch set 2 08/26/23, 11:23

    I think we also need to react on changes to the individual checkboxes - e.g., when I use the new "Toggle all" checkbox and then manually unselect one of the checked checkboxes, the ""Toggle all" checkbox remains checked. Or when you manually select all checkboxes, the "Toogle all" checkbox should automatically be checked. As an example, see the "selectCheckBox" FormEngine component.
  9. Sybille Peters commented on patch set 2 CR -1 08/29/23, 05:33

    Make change as suggested by Torben. Also, maybe look into providing a generic solution as ViewHelper.
  10. Sybille Peters uploaded patch set 3 CR -1 V +1 09/16/23, 16:24

  11. core-ci voted on patch set 3 V +1 09/16/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46625

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 09/18/23, 14:19

  13. Stefan Bürk voted on patch set 3 V +2 CR +2 09/18/23, 15:09

  14. Stefan Bürk merged patch set 4 09/18/23, 15:09