Review main Merged

80546[BUGFIX] Fix classloader dump after extension install

Benjamin Kott CR +2 V +2 Normal +38 −30 updated 08/15/23, 09:27

Commit message

With #101596 event listener registrations were migrated to
PHP attributes. Service registrations may only be performed
on non-static methods with symfony/dependency-injection <6.3 [1].
This caused the 'non-composer-class-loader' events to be silently
skipped, which is why no class loading information was dumped.
ClassLoadingInformation event listeners are moved into a separate
service with an instance method to circumvent this bug in
symfony/dependency-injection.

Also stray and unneeded Services.yaml configuration is removed.
(public: false is the default and does not need to be set at all)

[1] https://github.com/symfony/symfony/pull/47066

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1722

  1. Benjamin Kott uploaded patch set 1 08/14/23, 10:51

  2. core-ci voted on patch set 1 V +1 08/14/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45476

  3. Benjamin Kott updated the commit message in patch set 2 V +1 08/14/23, 11:09

  4. core-ci voted on patch set 2 V +1 08/14/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45477

  5. Oliver Klee voted on patch set 2 CR +1 08/14/23, 11:55

  6. Andreas Kienast commented on patch set 2 08/14/23, 11:56

    I think we should cover 12.4 and 11.5 as well.
  7. Benjamin Kott commented on patch set 2 CR -2 08/14/23, 12:17

    ignore patch for now - events not triggered anymore
  8. Benjamin Franzke uploaded patch set 3 CR +1 V +1 08/15/23, 05:39

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  9. core-ci voted on patch set 3 V +1 08/15/23, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45492

  10. Benjamin Kott voted on patch set 3 CR 0 08/15/23, 06:06

  11. Benjamin Franzke uploaded patch set 4 V +1 08/15/23, 06:18

  12. Benjamin Franzke commented on patch set 4 08/15/23, 06:18

    Reply

    Not needed, as the event listeners attributes were only merged into main.
  13. core-ci voted on patch set 4 V +1 08/15/23, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45493

  14. Oliver Klee voted on patch set 4 CR +1 08/15/23, 08:10

  15. Stefan Bürk voted on patch set 4 CR +1 08/15/23, 08:11

  16. Stefan Bürk commented on patch set 4 08/15/23, 08:39

    Maybe I'm wrong, but done it multiple times. This change also resolves #101681 https://forge.typo3.org/issues/101681 on extension removal/uninstall. Or not ? At least, the autoloading information are correctly removed with this change. Therefore, I would say we can add a resolves line for #101681 - or not ?
  17. Stefan Bürk updated the commit message in patch set 5 CR +1 V +1 08/15/23, 09:10

  18. Stefan Bürk commented on patch set 5 V +1 CR +1 08/15/23, 09:11

    Reply

    Done
  19. Stefan Bürk commented on patch set 5 08/15/23, 09:15

    Note: Could not find any other static function used as eventlister. So this should be the only occurance for this case.
  20. core-ci voted on patch set 5 V +1 08/15/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45498

  21. Benjamin Franzke voted on patch set 5 V +2 CR +2 08/15/23, 09:27

  22. Benjamin Franzke merged patch set 6 08/15/23, 09:27