Review 11.5 Merged

80548[BUGFIX] Fix Undefined array key warning in InlineRecordContainer

Thomas Hohn CR +2 V +2 Easy +3 −2 updated 08/15/23, 13:26

Commit message

Fix undefined array key 0 in `InlineRecordContainer` by adding
a null coalescing operator and handling `$uid` properly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Thomas Hohn uploaded patch set 1 08/14/23, 11:52

  2. Oliver Klee updated the commit message in patch set 2 08/14/23, 11:56

  3. Oliver Klee commented on patch set 2 08/14/23, 11:58

    InlineRecordContainer.php:548

    `$uid` is not a boolean. I'd prefer to handling this in a type-appropriate way (for added/changed code), e.g., like this: `&& (int)$uid !== 0` What do you think?
  4. Thomas Hohn commented on patch set 2 08/14/23, 12:01

    InlineRecordContainer.php:548 Reply

    I'm not sure the cast is necessary - and would prefer && ($uid > 0) then
  5. core-ci voted on patch set 1 V +1 08/14/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45480

  6. core-ci voted on patch set 2 V +1 08/14/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45481

  7. Oliver Klee commented on patch set 2 08/14/23, 12:18

    InlineRecordContainer.php:548 Reply

    Sounds good to me!
  8. Thomas Hohn uploaded patch set 3 V +1 08/14/23, 12:31

  9. Thomas Hohn commented on patch set 3 08/14/23, 12:32

    InlineRecordContainer.php:548 Reply

    Ack
  10. core-ci voted on patch set 3 V +1 08/14/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45482

  11. Oliver Klee voted on patch set 3 V +1 CR +1 08/14/23, 13:00

  12. Jörg Bösche voted on patch set 3 CR +1 08/14/23, 19:04

  13. Stefan Bürk voted on patch set 3 V +2 CR +2 08/15/23, 13:26

  14. Stefan Bürk merged patch set 4 08/15/23, 13:26