80548[BUGFIX] Fix Undefined array key warning in InlineRecordContainer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Jörg Bösche +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Thomas Hohn uploaded patch set 1 08/14/23, 11:52
-
Oliver Klee updated the commit message in patch set 2 08/14/23, 11:56
-
Oliver Klee commented on patch set 2 08/14/23, 11:58
-
Thomas Hohn commented on patch set 2 08/14/23, 12:01
InlineRecordContainer.php:548ReplyI'm not sure the cast is necessary - and would prefer && ($uid > 0) then -
core-ci voted on patch set 1 V +1 08/14/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45480
-
core-ci voted on patch set 2 V +1 08/14/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45481
-
Oliver Klee commented on patch set 2 08/14/23, 12:18
InlineRecordContainer.php:548ReplySounds good to me! -
Thomas Hohn uploaded patch set 3
V +108/14/23, 12:31 -
Thomas Hohn commented on patch set 3 08/14/23, 12:32
InlineRecordContainer.php:548ReplyAck -
core-ci voted on patch set 3 V +1 08/14/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45482
-
Oliver Klee voted on patch set 3 V +1 CR +1 08/14/23, 13:00
-
Jörg Bösche voted on patch set 3 CR +1 08/14/23, 19:04
-
Stefan Bürk voted on patch set 3 V +2 CR +2 08/15/23, 13:26
-
Stefan Bürk merged patch set 4 08/15/23, 13:26
InlineRecordContainer.php:548