80566[TASK] Remove "final" keyword from classes and methods
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 456
- Build/Scripts/annotationChecker.php+1 −1
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php+1 −1
- typo3/sysext/adminpanel/Classes/Log/LoggingConnection.php+1 −1
- typo3/sysext/adminpanel/Classes/Log/LoggingDriver.php+1 −1
- typo3/sysext/adminpanel/Classes/Log/LoggingStatement.php+1 −1
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php+1 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+1 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LinkController.php+1 −1
- typo3/sysext/backend/Classes/EventListener/AfterBackendPageRenderEventListener.php+1 −1
- typo3/sysext/backend/Classes/EventListener/FailedLoginAttemptNotification.php+1 −1
- typo3/sysext/backend/Classes/Form/Processor/SelectItemProcessor.php+1 −1
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+1 −1
Show 436 more files
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php+1 −1
- typo3/sysext/backend/Classes/Middleware/SudoModeInterceptor.php+1 −1
- typo3/sysext/backend/Classes/Module/BaseModule.php+2 −1
- typo3/sysext/backend/Classes/Module/ModuleRegistry.php+1 −1
- typo3/sysext/backend/Classes/Search/EventListener/AddLiveSearchResultActionsListener.php+1 −1
- typo3/sysext/backend/Classes/Search/EventListener/ExcludePagesFromSearchFieldsLookup.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/DemandProperty.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/MutableSearchDemand.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/SearchDemand.php+2 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItem.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItemAction.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchProviderRegistry.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchRepository.php+1 −1
- typo3/sysext/backend/Classes/Security/SudoMode/Access/RouteAccessSubject.php+2 −1
- typo3/sysext/backend/Classes/Security/SudoMode/Exception/RequestGrantedException.php+1 −1
- typo3/sysext/backend/Classes/Security/SudoMode/Exception/VerificationRequiredException.php+1 −1
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+1 −1
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php+1 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplateFactory.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/Enumeration/InformationStatus.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/PageTsBackendLayoutDataProvider.php+1 −1
- typo3/sysext/backend/Classes/View/BackendViewFactory.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/LanguageColumnViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+1 −1
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/Display/TableAccessViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/IsArrayViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/MfaStatusViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+1 −1
- typo3/sysext/core/Classes/Adapter/EventDispatcherAdapter.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderManifest.php+1 −1
- typo3/sysext/core/Classes/Authentication/JsConfirmation.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/ApcuBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/DatabaseSchemaService.php+1 −1
- typo3/sysext/core/Classes/Core/Event/WarmupBaseTcaCache.php+1 −1
- typo3/sysext/core/Classes/Core/RequestId.php+1 −1
- typo3/sysext/core/Classes/Country/CountryFilter.php+1 −1
- typo3/sysext/core/Classes/Database/Driver/PDOMySql/Driver.php+1 −1
- typo3/sysext/core/Classes/Database/Driver/PDOPgSql/Driver.php+1 −1
- typo3/sysext/core/Classes/Database/Driver/PDOSqlite/Driver.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/PageIdListRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BigIntDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BinaryDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BitDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/CharDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DateDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DateTimeDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DoubleDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/EnumDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/JsonDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/LongBlobDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/LongTextDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumBlobDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumIntDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/MediumTextDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/NumericDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/RealDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/SetDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/SmallIntDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TimeDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TimestampDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyBlobDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyIntDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/TinyTextDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/VarBinaryDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/VarCharDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/YearDataType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateColumnDefinitionItem.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateDefinition.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateForeignKeyDefinitionItem.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateIndexDefinitionItem.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateTableClause.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateTableStatement.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/Identifier.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/IndexColumnName.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/ReferenceDefinition.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/SchemaInformation.php+1 −1
- typo3/sysext/core/Classes/DataHandling/SoftReference/SoftReferenceParserResult.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/ConsoleCommandPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/ListenerProviderPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/LoggerAwarePass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/MessageHandlerPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/MessengerMiddlewarePass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/MfaProviderPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/PublicServicePass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/SingletonPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/SoftReferenceParserPass.php+1 −1
- typo3/sysext/core/Classes/Domain/ConsumableString.php+1 −1
- typo3/sysext/core/Classes/EventDispatcher/NoopEventDispatcher.php+1 −1
- typo3/sysext/core/Classes/Http/AbstractApplication.php+1 −1
- typo3/sysext/core/Classes/Localization/TcaSystemLanguageCollector.php+1 −1
- typo3/sysext/core/Classes/Messenger/BusFactory.php+1 −1
- typo3/sysext/core/Classes/Messenger/DoctrineTransportFactory.php+1 −1
- typo3/sysext/core/Classes/Messenger/HandlersLocatorFactory.php+1 −1
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php+1 −1
- typo3/sysext/core/Classes/Package/PseudoServiceProvider.php+1 −1
- typo3/sysext/core/Classes/Page/ImportMapCacheWarmer.php+1 −1
- typo3/sysext/core/Classes/Pagination/ArrayPaginator.php+1 −1
- typo3/sysext/core/Classes/Pagination/SimplePagination.php+1 −1
- typo3/sysext/core/Classes/Pagination/SlidingWindowPagination.php+1 −1
- typo3/sysext/core/Classes/PasswordPolicy/Validator/AbstractPasswordValidator.php+4 −4
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/FileDeletionAspect.php+1 −1
- typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php+1 −1
- typo3/sysext/core/Classes/Resource/DuplicationBehavior.php+1 −1
- typo3/sysext/core/Classes/Resource/MetaDataEventListener.php+1 −1
- typo3/sysext/core/Classes/Resource/MimeTypeCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/MimeTypeDetector.php+1 −1
- typo3/sysext/core/Classes/Schema/Struct/SelectItem.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Reporting/Report.php+2 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Reporting/Resolution.php+2 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/HashProxy.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/HashValue.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationCollection.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationSuggestion.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyProvider.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyRegistry.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Scope.php1+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceCollection.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/UriValue.php+1 −1
- typo3/sysext/core/Classes/Site/Entity/SiteSettings.php+1 −1
- typo3/sysext/core/Classes/Type/Bitmask/BackendGroupMountOption.php+1 −1
- typo3/sysext/core/Classes/Type/Bitmask/PageTranslationVisibility.php+1 −1
- typo3/sysext/core/Classes/Type/Bitmask/Permission.php+1 −1
- typo3/sysext/core/Classes/Type/Icon/IconState.php+1 −1
- typo3/sysext/core/Classes/Type/Map.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/CurrentObjectPath/CurrentObjectPath.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/CurrentObjectPath/CurrentObjectPathStack.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/ChildNode.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/ReferenceChildNode.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Traverser/AstTraverser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstConstantCommentVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstNodeFinderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstSortChildrenVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/CommentAwareAstBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AtImportInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionElseInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTyposcriptInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/DefaultTypoScriptInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/DefaultTypoScriptMagicKeyInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ExtensionStaticInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/FileInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeStaticFileDatabaseInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeStaticFileFileInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeTyposcriptInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/RootInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SegmentInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SiteInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/StringInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SysTemplateInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/TsConfigInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/ConditionVerdictAwareIncludeTreeTraverser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/IncludeTreeTraverser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeAstBuilderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeCommentAwareAstBuilderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionAggregatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionEnforcerVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeNodeFinderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSetupConditionConstantSubstitutionVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSourceAggregatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateRepository.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/BlockCloseLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/CommentLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionElseLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionStopLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/EmptyLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierAssignmentLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierBlockOpenLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierCopyLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierFunctionLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierReferenceLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierUnsetLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ImportLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ImportOldLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/InvalidLine.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineStream.php+2 −2
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/AbstractTokenStream.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/ConstantAwareTokenStream.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/IdentifierToken.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/IdentifierTokenStream.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/Token.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenStream.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LosslessTokenizer.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LossyTokenizer.php+1 −1
- typo3/sysext/core/Classes/TypoScript/FrontendTypoScript.php+1 −1
- typo3/sysext/core/Classes/TypoScript/PageTsConfig.php+1 −1
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.php+1 −1
- typo3/sysext/core/Classes/TypoScript/UserTsConfig.php+1 −1
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+1 −1
- typo3/sysext/core/Documentation/Changelog/10.0/Feature-84112-SymfonyDependencyInjectionForCoreAndExtbase.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.3/Feature-94345-AutoDetectEventTypes.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-93494-NewPSR-14ModifyQueryForLiveSearchEvent.rst+1 −1
- typo3/sysext/dashboard/Classes/DependencyInjection/DashboardWidgetPass.php+1 −1
- typo3/sysext/dashboard/Classes/EventListener/AfterBackendPageRenderEventListener.php+1 −1
- typo3/sysext/dashboard/Classes/ViewHelpers/Widget/ButtonViewHelper.php+1 −1
- typo3/sysext/extbase/Classes/DependencyInjection/TypeConverterPass.php+1 −1
- typo3/sysext/extbase/Classes/EventListener/AddDefaultModuleIcon.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+4 −4
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilderDefaultValues.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+3 −1
- typo3/sysext/extbase/Classes/Pagination/QueryResultPaginator.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/ClassesConfigurationFactory.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/PropertyCharacteristics.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AlphanumericValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/BooleanValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/DisjunctionValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/UrlValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorClassNameResolver.php+1 −1
- typo3/sysext/extensionmanager/Classes/DependencyInjection/ExtensionRemotePass.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Be/TriggerViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/InstallationStateCssClassViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+1 −1
- typo3/sysext/felogin/Classes/Event/ProcessRequestTokenListener.php+1 −1
- typo3/sysext/felogin/Classes/Redirect/RedirectMode.php+1 −1
- typo3/sysext/filelist/Classes/Pagination/ResourceCollectionPaginator.php+1 −1
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContextFactory.php+1 −1
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/LinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/TrimViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/NonceViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+1 −1
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+0 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+0 −1
- typo3/sysext/form/Classes/Mvc/Property/Exception/TypeConverterException.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/EmptyValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+1 −1
- typo3/sysext/form/Classes/Slot/FilePersistenceSlot.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Be/MaximumFileSizeViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/Aspect/FileMetadataOverlayAspect.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+1 −1
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Service/DatabaseSchemaService.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+1 −1
- typo3/sysext/install/Classes/Controller/InstallerController.php+1 −1
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −1
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+1 −1
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+1 −1
- typo3/sysext/install/Classes/Updates/BackendGroupsExplicitAllowDenyMigration.php+1 −1
- typo3/sysext/install/Classes/Updates/SysTemplateNoWorkspaceMigration.php+1 −1
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/NoSpaceViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −1
- typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php+1 −1
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ProviderRegistry.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+1 −1
- typo3/sysext/lowlevel/Classes/DependencyInjection/ConfigurationModuleProviderPass.php+1 −1
- typo3/sysext/reactions/Classes/Pagination/DemandedArrayPaginator.php+1 −1
- typo3/sysext/reactions/Classes/Validation/CreateRecordReactionTable.php+1 −1
- typo3/sysext/redirects/Classes/Configuration/CheckIntegrityConfiguration.php+1 −1
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php+1 −1
- typo3/sysext/redirects/Classes/EventListener/AddPlainSlugReplacementSource.php+1 −1
- typo3/sysext/redirects/Classes/EventListener/AfterBackendPageRendererEventListener.php+1 −1
- typo3/sysext/redirects/Classes/EventListener/IncrementHitCount.php+1 −1
- typo3/sysext/redirects/Classes/Hooks/DispatchNotificationHook.php+1 −1
- typo3/sysext/redirects/Classes/Message/RedirectWasHitMessage.php+1 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/PageTypeSource.php+1 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/PlainSlugReplacementRedirectSource.php+1 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/RedirectSourceCollection.php+1 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItem.php+1 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItemFactory.php+1 −1
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageIdViewHelper.php+1 −1
- typo3/sysext/reports/Classes/Report/WarningsForAboutModule.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/AvailableSchedulerTasksController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerSetupCheckController.php+1 −1
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+1 −1
- typo3/sysext/seo/Classes/Widgets/Provider/PagesWithoutDescriptionDataProvider.php+1 −1
- typo3/sysext/seo/Classes/Widgets/PagesWithoutDescriptionWidget.php+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+1 −1
- typo3/sysext/sys_note/Classes/Provider/ButtonBarProvider.php+1 −1
- typo3/sysext/sys_note/Classes/Provider/InfoModuleProvider.php+1 −1
- typo3/sysext/sys_note/Classes/Provider/PageModuleProvider.php+1 −1
- typo3/sysext/t3editor/Classes/EventListener/InitializeT3editorInEditFileForm.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+1 −1
- typo3/sysext/tstemplate/Classes/Hooks/DataHandlerClearCachePostProcHook.php+1 −1
- typo3/sysext/webhooks/Classes/DependencyInjection/WebhookCompilerPass.php+1 −1
- typo3/sysext/webhooks/Classes/Message/FileAddedMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Message/FileRemovedMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Message/FileUpdatedMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Message/LoginErrorOccurredMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Message/MfaVerificationErrorOccurredMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Message/PageModificationMessage.php+1 −1
- typo3/sysext/webhooks/Classes/Pagination/DemandedArrayPaginator.php+1 −1
- typo3/sysext/workspaces/Classes/EventListener/PageTreeItemsHighlighter.php+1 −1
- typo3/sysext/workspaces/Classes/MessageHandler/StageChangeNotificationHandler.php+1 −1
- typo3/sysext/workspaces/Classes/Messages/StageChangeMessage.php+1 −1
Review log 5565
Show 3240 earlier messages
-
Claus Due uploaded patch set 1 08/16/23, 11:48
-
core-ci voted on patch set 1 V -1 08/16/23, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45550
-
Claus Due updated the commit message in patch set 2
V -108/16/23, 11:50 -
core-ci voted on patch set 2 V -1 08/16/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45551
-
Claus Due updated the commit message in patch set 3
V -108/16/23, 11:54 -
core-ci voted on patch set 3 V -1 08/16/23, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45553
-
Oliver Klee commented on patch set 3 CR -1 08/16/23, 12:05
GeneralUtility.php:3037This looks like an unintended change (possibly from a search'n'replace).CompleteEnumeration.php:25There is no need to make the testing fixtures non-final again. -
Oliver Klee commented on patch set 3 08/16/23, 12:23
Have you checked that you haven't un-finalized any classes that are intended to implement an interface (i.e., where one should program against the interface instead of against the concrete class)? -
Claus Due uploaded patch set 4
CR -1V -108/16/23, 12:29 -
core-ci voted on patch set 4 V -1 08/16/23, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45557
-
Christian Kuhn voted on patch set 4 CR -2 08/16/23, 12:31
-
Claus Due commented on patch set 4 08/16/23, 12:40
Reply
Yes - in all but two cases there is no unique interface for the implementation. Some aside from those two cases do share an interface, but the interface isn't unique to the implementation (e.g. ViewHelperInterface). The two cases are: * MfaProviderManifest - this one does have a specific interface, MfaProviderManifestInterface, but the implementation (not the interface) is used in the compiler pass that configures MFA providers. * GenericMetaTagManager - this specific implementation is returned as fallback. Declaring it final and not fitting it with a specific interface (e.g. FallbackMetaTagManagerInterface) means that the fallback meta tag manager can never be replaced.GeneralUtility.php:72ReplyDoneGeneralUtility.php:3037ReplyDoneCompleteEnumeration.php:25ReplyDone -
Christian Kuhn commented on patch set 4 08/16/23, 12:51
This will of course not make it. A few examples: * events are a contract between the calling class and the event consumer. xclassing this can kill other listeners and/or the calling class. final will stay. * VH's are leaf classes. they are not meant to be extended. doing so treats a VH as API, which it isn't. don't do it. final will stay. additionally, VH's can be exchanged by configuration if needed (if you for instance want to substitute the image-VH with your own one, you can do so). and: VH's of exts like adminpanel are internal and must not be used by 3rd party. * nodeFactory and similar: it does not make sense to xclass this, the factory is "complete": everything it does can be changed using configuration. * about mocking: classes like ModuleTemplate must not be mocked - this class is meant to be used in controllers. unit tests for controllers don't make sense since they're glue code. use functional or acceptance tests. -
Claus Due uploaded patch set 5
V -108/16/23, 13:09Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Stefan Bürk commented on patch set 4 CR -2 08/16/23, 13:10
Reply
Agree on the reasons given by Christian, explained the reson and decision for makeing these things final. Mocking events does not make sense. Use them. EventLister tests as unit tests does not make much sense and better suited for functional tests. Same goes for other things which are better suited as functional tests than unit tests. This change reversts things implemented based on reasons and decisions. Will not make it. -
Claus Due commented on patch set 5 08/16/23, 13:26
Reply
* Events: it is not the responsibility of the core to guarantee that any and all third-party extensions will never risk breaking core business logic. * VHs: strongly disagree. ViewHelpers are designed to be overrideable and namespaces are designed to be merged/union'ed when resolving a ViewHelper. Overriding a VH does not imply that said VH is public API. * NodeFactory: even if a class is "complete" that doesn't necessarily mean that it also must be "final". * Mocking ModuleTemplate: the case in point is not a controller. It is an event that carries a ModuleTemplate instance, and the event is programmed to that specific implementation. A unit test case for an event listener is absolutely a valid use case for unit tests. @Stefan mocking events does absolutely make sense - when, just for example, constructing an instance of the event requires many constructor arguments, some of which are themselves declared final. Not being able to test-double the event means you have no option but to construct the instance - and when this in turn requires also constructing several of the constructor arguments that *also* cannot be test-doubled, it compounds the problem to a potentially very deep degree of deps. Besides: this patch is created precisely because I am strongly disagreeing with the validity of the reasons stated for declaring these things final in the first place. If we cannot discuss such decisions, then development of TYPO3 is no longer a group- and community effort: that makes it essentially a gatekept project where decisions are made by a core group and can never be questioned by community members; such as I am doing right now. Please listen to the reasons instead of outright dismissing them. Every "final" keyword you introduce, makes the project as a whole a more unfriendly/unflexible mass of totally unreplaceable and un-doubleable code. Part of what makes TYPO3 so great for application development is precisely that we can modify it to our purposes without having to wait severeal years (and inevitably risking just having it dismissed, case in point...) or having to wait for a next LTS release by creating a merge request to introduce an event or whatever that fits with our precise use case. -
core-ci voted on patch set 5 V -1 08/16/23, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45559
-
Andreas Kienast commented on patch set 5 CR -2 08/17/23, 11:30
My 2 cents here: I don't get the discussion especially about events. Events are some kind of a blackbox. Allowing extensibility doesn't make any sense as said classes are created via `new` in consuming code anyway. It's completely fine to discuss this on a class-basis, but doing rambo patches that obviously are pure search & replace doesn't help the cause. I highly advice using proper functional tests that gives you the power of dependency injection that allows to override definitions. If this doesn't work for tests only, this a bug that needs to be addressed. Claiming that TYPO3 is a "gatekept project" is a bold take, especially looking at the amount of contributions done during T3DD23 done by first time contributors. -
Claus Due commented on patch set 5 08/17/23, 12:21
Reply
I tried bringing this topic up in #typo3-cms-coredev but only got actual engagement from one other person. Plus, I like to demonstrate and visualise my points with code - among other things, to give you an idea of the _scope_ of the problem (378 occurrences). I've already described the issue with test doubles elsewhere. Suggesting an even more complex solution just to work around the "final" decision isn't helpful - sorry. Please read carefully what I actually said. I did not claim that TYPO3 is a gatekept project. I said that IF we can no longer discuss such things and immediately get dismissed outright, *THEN* TYPO3 risks becoming a gatekept project, specifically in that decisions made within a small group can never be questioned. It has nothing to do with how many or few first-time contributors create patches during T3DD... -
Oliver Klee commented on patch set 5 08/17/23, 13:18
@Claus, my 2¢ on your approach with this ticket: 1. For the future, if a change is only for demonstration purposes for discussion, I think marking it as [WIP] will help avoid misunderstandings so that people don't consider it as something that's actually intended to get merged. Also, it will keep people from spending time on reviews (as I did), following the "Be respectful of people's volunteer time." advice from the TYPO3 Code of Conduct. https://typo3.org/coc (I personally am happy to review the occasional change that's intended to get merged, but I'm not happy spending time on reviews for changes where my effort is for naught because the change wasn't planned for merging in the first place.) 2. For cases where a specific class being `final` creates a specific problem (which could totally happen), I think it would work better to have a dedicated ticket explaining the problem and smaller, dedicated change. I'd recon that this would greatly increase the chances of the corresponding change actually getting merged. -
Claus Due commented on patch set 5 08/17/23, 13:36
Reply
@Oliver I sincerely do want this MR to be merged. It's not only for demonstration purposes. I created the patch since I was not able to get more than one response when I posed the question and "don't final" advise in #typo3-cms-coredev. And I would sincerely want the "final" keyword to be removed from every class and function. For me personally, it doesn't matter if the class is an internal contract, is considered complete, is a leaf class or whatever the rationale may be. As I've mentioned in #typo3-cms-coredev, the risk associated with XCLASS is mine to take, not TYPO3's to prevent. And intentionally destroying the ability to mock things that are involved in API subscribers is pretty bad, at least IMHO. I do respect volunteers' time (being a volunteer myself). But I'd like the volunteers to also respect my time (and ability to do my job, and my sanity) by not making blanket decisions like "final"'ing everything that's not considered public API. Because that really, really hurts my ability to get the job done efficiently. It's incredibly frustrating, especially since the main reason appears to be "we don't want you to be able to do that". It would also be insanely noisy to create 378 issues and merge requests asking for "final" to be removed from individual classes/methods. So I'd rather not have to do that. The problem it creates is always the same: inability to replace implementations, plus inability to double it in tests. -
Oliver Klee commented on patch set 5 08/17/23, 13:49
Reply
Ah, I understand. Thank you for explaining this! -
Oliver Klee commented on patch set 5 08/17/23, 13:49
Reply
Ack -
Benni Mack commented on patch set 5 08/17/23, 19:33
as for the "making events" final, there is a very good reason for not making events final in production code: If TYPO3 Core would have an "AuthenticationEvent" and then add a "AuthenticatedViaCookieEvent" and a "AuthenticatedViaCredentialsEvent" as extensions of this event, then Event listeners can either listen to a specific subclass or to the AuthenticationEvent in general. By declaring the AuthenticationEvent final (thus, most of our code), we ensure developers that if the implement against the AuthenticationEvent that their code will NOT have side effects in future versions, when a new event is added, as it cannot be extended from this specific event. PSR-14 was intended EXACTLY with this in mind - yes, I was part of the PSR working group. Most of the PSR-14 events only have a basic set of constructor arguments, with simple types most of the times. I have written 100s of unit tests when working with Events, and it was never once a pain where I had the necessity to test. However, I don't really know what you are testing with Unit tests where you have a hard-time, let me know and I am happy to help you out. Maybe a Functional Test would suit better in this case? -
Ingo Fabbri commented on patch set 5 08/17/23, 22:24
Especially ViewHelper should still be extendable. If you don't implement against interfaces, why seal everything with "final" anyway? This makes it harder for people to resolve/enhance/change "core-behaviour". However, I don't see any disadvantage in declaring PSR event classes final. These are usually pure "transport objects". But yes, for example: why is class SearchDemand final? And in between I also see "final" on constructor, but the class not. I think this is really bad. Who actually came up with that? Allow to extend the class but not able to implement an own constructor? Is there a reason to do that? -
Claus Due commented on patch set 5 08/18/23, 00:09
Reply Unresolved
I understand that most of the time, the events are fairly simple transport objects. Most of the time - but definitely not all of the time. I don't care about the times when it's a simple trsnsport object but I greatly care about the times it is not, and when the Event's dep/deps is also declared final. And I see the trend towards this happening more and more. Most recently I got a headache from ModifyPageLayoutContentEvent because its constructor requires a ModuleTemplate instanc, ModuleTemplate is declared final, and has 8 (!!) constructor deps of its own that I'd then also need to mock (and repeat this recursively for all future cases where "final" is added to one of those secondary deps). Here's the abuse I had to turn to, to get this marginally working - but notice, if I had to call any method on ModuleTemplate from my listener, I'd be up the proverbial s**t creek without a paddle: https://github.com/FluidTYPO3/flux/blob/development/Tests/Unit/Integration/Event/ModifyPageLayoutContentEventListenerTest.php#L32C58-L32C72 (and for fun, imagine the amount of data fixtures I'd have to write for the same 4 paths to be covered by functional tests). In other cases I know I will be having future headaches from the decision to "final" NodeFactory, because it is a dependency of literally every custom FormEngine component I might write. In all of those cases I'll have to turn to the same reflection abuse as above, and in all those cases I will be in so much pain if I ever have to mock a method on NodeFactory. But more to the point: I *want* to be able to write a unit test. I *don't* want to be forced to write a functional test just because the framework (for whatever reason) decided the deps of my SUT needed to be final. And IMHO, functional tests are not a better choice for something like guarding that an event listener reacts correctly with all possible combinations of input criteria within the event. And I *really* don't want to have to install something like https://packagist.org/packages/dg/bypass-finals which on-the-fly rewrites source code of TYPO3 just to be able to write my tests. I'd much rather TYPO3 didn't force me into such a situation. -
Torben Hansen commented on patch set 5 08/18/23, 10:53
In case of many of the ext:fluid ViewHelpers I agree, that is was the wrong decision to declare them all as final. Extending existing Fluid ViewHelpers is impossible now and users will start to duplicate code into their own projects just to make a small adaption. Most of the community feedback on this topic is also pretty clear: ext:fluid ViewHelpers should not be final. In case of PSR-14 events I see no problem declaring them final. However, I think we should try to avoid declaring e.g. constructors in Demand objects and other "internal" classes as final (if it is not really required), since this has negative effects on one of the main benefits of TYPO3 - the extendability. As Claus wrote in the core-dev channel: If something is marked as "internal", users know, that things may break, it they use/extend the class in custom projects. But declaring classes as final to avoid users from extending/overwriting them is IMO not something the TYPO3 project will benefit from on a mid/long term. Since many of the "final"-declarations have been introduced with TYPO3 v12, the community feedback may be some kind of silent at the moment regarding this topic, since most users will update to v12 with some month of delay after the LTS release. But I'm think, that some of those changes (e.g. on ext:fluid ViewHelpers) will lead to more negative feedback / developer frustration. -
Claus Due commented on patch set 5 08/18/23, 12:14
I could compromise on the PSR-14 events. Those wouldn't be as much of a pain - as long as their (potentially complex object) constructor deps aren't also final. But everything else, I strongly believe should not be "final". -
Torben Hansen commented on patch set 5 08/27/23, 10:18
Regarding the ext:fluid ViewHelpers I talked to some more community members to evaluate, how existing ViewHelpers are extended. Actually, most often an additional argument is added and/or the `render()` method is overwritten. This however incorporates, that most likely the whole ext:fluid ViewHelper logic is copied 1:1 and adapted. The only "advantage" of this is, that the `f:` namespace can still be used. So I correct my previous statement, that ext:fluid ViewHelpers should not be `final`, since most of the ViewHelpers basically only have 2 functions (`initializeArguments()` and `render()`) and overwriting both most likely makes no sense and a custom ViewHelper should be the way to go there. -
Claus Due commented on patch set 5 08/28/23, 11:27
Reply
> Actually, most often an additional argument is added and/or the render() method is overwritten. Both of which would be impossible if the class is defined `final`. Instead, your only option would be to copy the entire class, register ever original argument and all the business logic involved with processing those arguments. And don't forget the valid use cases that exist for replacing the inherited methods (postParse, compile, validateArguments, handleAdditionalArguments, and much more) that would also be completely blocked off. It's not just about the render+initializeArguments methods. It's about every public and protected method and even some protected attributes. -
Benjamin Franzke marked it work in progress 08/29/23, 17:09
-
Claus Due uploaded patch set 6
V -110/09/23, 14:35Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 6 V -1 10/09/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47597
-
Claus Due uploaded patch set 7
V -110/09/23, 15:10Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 7 V -1 10/09/23, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47599
-
Claus Due uploaded patch set 8
V -110/09/23, 15:23Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Claus Due marked it ready for review 10/09/23, 15:31
-
core-ci voted on patch set 8 V -1 10/09/23, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47600
-
Claus Due commented on patch set 8 10/09/23, 15:32
* Rebased * Restored "final" keyword on Event classes * Removed "final" keyword from classes which had it added since August 16 -
Claus Due uploaded patch set 9
V -110/09/23, 15:36Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
-
Claus Due uploaded patch set 10 10/09/23, 15:37
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 9 V +1 10/09/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47602
-
core-ci voted on patch set 10 V +1 10/09/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47603
-
Oliver Klee wrote 10/09/23, 16:15
Removed reviewer Oliver Klee. -
Thomas Hohn voted on patch set 10 V +1 CR +1 10/10/23, 11:17
-
Jan Delius commented on patch set 10 CR +1 10/10/23, 12:04
Really need this for ViewHelpers. Some times we only want to add a single html attribute or something and have to copy the whole core logic. -
Oliver Eglseder commented on patch set 10 CR +1 10/10/23, 14:21
More than just 2ct: I read through the comments to get the gist of this change. Most of the points don't concern me, or I don't have an opinion about them, but there is one statement that I believe to be true above all: "It is not TYPO3's job to prevent XCLASSes, but rather mine to use them wisely and at your own risk." As a programmer with nearly 20 years of experience, including over 11 years in a professional job, I can tell you that there will always be an edge case where extending a class is necessary, regardless of whether it is considered complete or its behavior is fully configurable. We as humans are not able to grasp the infinite possibilities and challenges that other programmers have in their daily lives to implement requirements and fix bugs. A bit off topic but still part of the discussion: I do make my events final, but there are things i highly discourage. - More than 3 simple type parameters (Sounds like there is too much going on) - More than 1 non-prototype object parameter. Services should be injected in the listener, not passed via an event. Any object passed by an event should be a prototype or value object. An event with 8 constructor arguments sounds like there is some logic going on inside of the event or the arguments are required for some logic that is implement by some class that listens to it. I would want to mock it either. -
Friedemann Altrock commented on patch set 10 CR -1 10/10/23, 14:45
While I agree on some points made here, I think just removing final everywhere is the wrong choice. It would be better to qualify each change with concrete use cases. * ViewHelpers: explain why it cannot be done by having an argument additionalAttributes, show valid use case for overriding a core VH. * final non-interfaced dependencies: introduce interfaces where appropriate. I don't see why we can't have a ModuleTemplateInterface. * If you are fixing a bug by XLCASSing, consider using a composer patch instead. As is this patch is an ideological dispute which can be considered to be lost already, considering how the wider PHP ecosystem is gravitating towards "final" (symfony, doctrine). -
Frank Nägler wrote 10/10/23, 14:46
Removed cc Frank Nägler. -
Oliver Klee commented on patch set 10 CR -1 10/10/23, 14:56
Everybody: Gerrit is not a forum, and it neither the place for longer discussions nor for making big technical decisions. Also, please be aware the votes on Gerrit (as the TYPO3 Core contribution workflow uses them) don't work on a majority basis. Instead, changes only get merged if there are no negative votes (with very rare exceptions) and sufficient positive votes. This change here in its entirety is not in a state that the Core mergers would consent to getting it merged (as Lolli already explained some time ago). More +1s or more "me too"s here will not change that. If somebody needs some classes to be un-finalized, I propose first reducing the scope (e.g., a single class, or the adminpanel extension, or whatever poses a specific problem) in order to make both the change and the discussion smaller and easier to handle. (Claus, this is what I suggested a few weeks ago.) Also, I strongly recommend discussing this with the Core mergers beforehand and getting their approval before creating a new change with a reduced scope. Throwing the change here while knowing that the Core mergers will not accept it is not productive, and not a good use of anyone's time. -
Thomas Hohn commented on patch set 10 10/10/23, 14:58
I totally agree with with Oliver. I have also work with software in more then 25 years as a professional. I sometimes also need to XClass stuff, not that I like it or am proud of it - but for instead with the solr TYPO3 extension with have some additional requirements that the average user doesn't have and thus we have XClassed some of the stuff and some of it won't make it into the solr core. We also have XClasses of some other core stuff - because the turn around time for getting it fixed in the core made it necessary. We have more that 3000 TYPO3 installations - so occasionally we see race conditions - some of the get fixes through PR from our self and other never make it into the core since it's caused by our specific use of TYPO3. We are fully aware of the risks - but try to mitigate them by providing fixes and remove XClasses as soon as we can again. TYPO3 is very powerfull and has a fantastic ECO system - but let's keep it open and extensible by providing the correct decisions and not just finalise it. Regarding XClasses or composer patches - I personally prefer XClasses since with at lot of "identical" projects on the same project you only need the fix in one central place instead of X composer patches -
Claus Due commented on patch set 10 10/10/23, 15:09
Reply
> This change here in its entirety is not in a state that the Core mergers would consent to getting it merged (as Lolli already explained some time ago). More +1s or more "me too"s here will not change that. The state has changed since you last checked. For example, I omitted the PSR-14 events as a compromise since these are the least of the problem. The +1s and "me too"s will, if nothing else, serve as indicators that I'm not alone in wanting this changed. > If somebody needs some classes to be un-finalized, I propose first reducing the scope (e.g., a single class, or the adminpanel extension, or whatever poses a specific problem) in order to make both the change and the discussion smaller and easier to handle. (Claus, this is what I suggested a few weeks ago.) I'd rather fix the entire problem (and institute a rule not to repeat it) than repair the individual bits that were broken as people start to complain about them. One patch instead of many hundreds. > Also, I strongly recommend discussing this with the Core mergers beforehand and getting their approval before creating a new change with a reduced scope. Throwing the change here while knowing that the Core mergers will not accept it is not productive, and not a good use of anyone's time. I tried and failed - as I already mentioned. I am left with this patch as my last ditch effort to open some eyes to the problem and the rather severe scope of the final'ing which is continually getting worse. -
Felix Nagel voted on patch set 10 CR +1 10/10/23, 16:12
-
Torben Hansen wrote 10/10/23, 16:16
Removed cc Torben Hansen. -
Oliver Klee wrote 10/10/23, 16:38
Removed reviewer Oliver Klee with the following votes: * Code-Review-1 by Oliver Klee -
Johannes Rebhan commented on patch set 10 CR +1 10/11/23, 05:42
Making ViewHelpers final is destructive, unhelpful, doesn't improve code quality. The reasoning that people would rely on code that might change is bogus, because it applies to all core classes we regularly rely upon, that get changed no matter what anyway. This has forced our company A TON of cost refactoring ViewHelper in almost every project, on every upgrade, copying and duplicating core code that hasn't changed for easily more than 5+ years. ViewHelper code is some of the most stable code in the core. Final should be reserved for things that are so black boxed, that no one should ever attempt at understanding or relying upon things. It's the systematic version of @internal. -
Garvin Hicking commented on patch set 10 10/11/23, 07:50
I tried to not dive into this, because it's a "general stance"-problem like politics, but I can't help myself and need to get myself on the soapbox too. I understand both basic ideas: * Yes-Final: Allow refactoring, clear patterns/structure, education, support * No-Final: Nothing is true, everything is permitted. Allow to change all the things. We need to remind ourselves, that not only skilled developers use the TYPO3-API (or "pseudo-API" like ViewHelpers) for internal projects, but also people maintaining public extensions or people unsure about "proper" Design-Patterns, or when and what to XCLASS, extend, mock. Allowing people to "change everything" can create both support overhead, as well as "create facts" of people extending things, that the core itself never wanted to support. This can lead core development into a corner, where changing even "internal" methods may face issues of public or private implementations. This prevents refactoring without prejudice for larger goals. Ideally, those classes/methods would only get finalized at a point where solid API-alternatives exist, so that everything one wants to achieve is able to do. But realistically this is a chicken/egg issue. TYPO3 core can't really provide solid API-alternatives, as long as current workarounds and customizations are allowed. So from an educative point of view, it's IMO fair to cut off access to these classes, to state intent about those being subject to change or other APIs created around them. It also raises the awareness for people extending these things, that there are issues with it which need redesigning. Even though TYPO3 is huge, the core development is rather fragmented and small - so offering interfaces or abstract classes or services for everything is a huge amount of work, and it somewhere needs to begin. My feeling is that "finalizing" these areas was done with best intent, to improve internal usage. I don't think anyone in the core team is trying to "gate" access to the core here, but instead improve testing, quality and stability. Actually, it also forces the TYPO3 core development to provide better interfaces. Because they cannot simply defer to developers by saying "XCLASS it, if you need it". So new/improved APIs will be a natural effect of finalizing, as will be better patterns, less update clashes. Not only a skilled developer will extend 'final' classes if that gets allowed (again), but also public extension authors, and that is a concern to me. Personally I did get hurt by this, because I had to workaround a lot of "simple" ViewHelper extensions that we had, because I really believe Core ViewHelpers *are* part of an API, and basing off these should be possible. Ideally, a ViewHelper would be just so dumb that it only access API and not doing anyhting on their own. The f:image ViewHelper for example is clearing doing things on their own, and not extending that one hurts. So my bottom line is: Don't fight final, but fight for improving the actual interfaces, APIs and design patterns. So that "final" doesn't really hurt you, and just gives the core a set of classes they can work on without hurting any developers. I really love the steadiness of the TYPO3 eco system, and I would be so sad if this drives irrevokable barriers between exceptionally cool people and developers. -
Benjamin Kott voted on patch set 10 CR -2 10/11/23, 17:10
-
Oliver Hader commented on patch set 10 CR -2 10/18/23, 07:32
-2 since it blindly removes ALL `final` keywordsScope.php:29UnresolvedHa! No way! -
Mathias Brodala commented on patch set 10 10/18/23, 07:46
Reply Unresolved
Claus has left, so I don't think that the discussion will continue here. So IMO this can be abandoned and if at all restarted with a proper discussion first. -
Stefan Bürk abandoned the change 01/25/24, 10:40
-
Claus Due commented on patch set 10 01/25/24, 10:50
Are you just going to ignore every single point I made in this merge request and the discussion? -
Stefan Bürk restored the change 01/25/24, 11:35
-
Stefan Bürk commented on patch set 10 CR -2 01/25/24, 11:41
Reply
no one is talking about complete ignoring it. restored it now for your happiness. -
Georg Ringer abandoned the change 05/27/24, 21:32
as this issue won't be merged, I abandon it for cleanup reasons
GeneralUtility.php:72