Review main Merged

80567[TASK] Migrate @typo3/form/backend/form-editor to TypeScript

Benjamin Franzke CR +2 V +2 Expert +861 −1166 updated 08/28/23, 14:47

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1822

  1. Benjamin Franzke uploaded patch set 1 08/17/23, 07:00

    Initial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/17/23, 07:04

    Reindent file
  3. Benjamin Franzke uploaded patch set 3 08/17/23, 07:08

    Apply eslint fix
  4. Benjamin Franzke uploaded patch set 4 08/17/23, 07:15

    Manual eslint fixes
  5. Benjamin Franzke uploaded patch set 5 08/17/23, 08:01

    Convert to class syntax
  6. Benjamin Franzke uploaded patch set 6 08/19/23, 13:43

    Define types
  7. core-ci voted on patch set 6 V +1 08/19/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45629

  8. Benjamin Franzke marked it work in progress 08/22/23, 08:25

  9. Benjamin Franzke uploaded patch set 7 V +1 08/23/23, 06:50

    Improve types
  10. core-ci voted on patch set 7 V +1 08/23/23, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45701

  11. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  12. Andreas Kienast commented on patch set 7 08/24/23, 14:22

    form-editor.ts:79

    PhpStorm: Field can be readonly. Can be done later™.

    form-editor.ts:334

    I think this can be removed at a later point

    form-editor.ts:389

    PhpStorm: Local variable indexFromPropertyCollectionElement is redundant

    form-editor.ts:614

    PhpStorm: Local variable lastRenderable is redundant

    form-editor.ts:654

    Hint: Method is unused
  13. Benjamin Franzke uploaded patch set 8 V +1 08/24/23, 18:26

    Cosmetics
  14. Benjamin Franzke commented on patch set 8 08/24/23, 18:26

    form-editor.ts:79 Reply

    thx, cool. Done. looks like we should enable @typescript-eslint/prefer-readonly in eslint config.

    form-editor.ts:334 Reply

    Done

    form-editor.ts:389 Reply

    Done

    form-editor.ts:614 Reply

    Done

    form-editor.ts:654 Reply

    Thanks, good catch. Cannot be removed right now, as this is pulic API, but I added a todo for it to be deprecated.
  15. core-ci voted on patch set 8 V +1 08/24/23, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45796

  16. Benjamin Franzke rebased onto patch set 9 V +1 08/25/23, 05:03

    Rebase
  17. core-ci voted on patch set 9 V +1 08/25/23, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45810

  18. Andreas Kienast voted on patch set 9 V +1 CR +1 08/25/23, 05:56

  19. Christian Kuhn voted on patch set 9 V +1 08/28/23, 08:54

  20. Benjamin Kott voted on patch set 9 V +1 CR +1 08/28/23, 13:44

  21. Benjamin Franzke voted on patch set 9 V +2 CR +2 08/28/23, 13:45

  22. Benjamin Franzke merged patch set 10 08/28/23, 14:47