80567[TASK] Migrate @typo3/form/backend/form-editor to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1822
-
Benjamin Franzke uploaded patch set 1 08/17/23, 07:00
Initial-Upload git mv only -
Benjamin Franzke uploaded patch set 2 08/17/23, 07:04
Reindent file -
Benjamin Franzke uploaded patch set 3 08/17/23, 07:08
Apply eslint fix -
Benjamin Franzke uploaded patch set 4 08/17/23, 07:15
Manual eslint fixes -
Benjamin Franzke uploaded patch set 5 08/17/23, 08:01
Convert to class syntax -
Benjamin Franzke uploaded patch set 6 08/19/23, 13:43
Define types -
core-ci voted on patch set 6 V +1 08/19/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45629
-
Benjamin Franzke marked it work in progress 08/22/23, 08:25
-
Benjamin Franzke uploaded patch set 7
V +108/23/23, 06:50Improve types -
core-ci voted on patch set 7 V +1 08/23/23, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45701
-
Benjamin Franzke marked it ready for review 08/23/23, 08:44
-
Andreas Kienast commented on patch set 7 08/24/23, 14:22
form-editor.ts:79PhpStorm: Field can be readonly. Can be done later™.form-editor.ts:334I think this can be removed at a later pointform-editor.ts:389PhpStorm: Local variable indexFromPropertyCollectionElement is redundantform-editor.ts:614PhpStorm: Local variable lastRenderable is redundantform-editor.ts:654Hint: Method is unused -
Benjamin Franzke uploaded patch set 8
V +108/24/23, 18:26Cosmetics -
Benjamin Franzke commented on patch set 8 08/24/23, 18:26
form-editor.ts:79Replythx, cool. Done. looks like we should enable @typescript-eslint/prefer-readonly in eslint config.form-editor.ts:334ReplyDoneform-editor.ts:389ReplyDoneform-editor.ts:614ReplyDoneform-editor.ts:654ReplyThanks, good catch. Cannot be removed right now, as this is pulic API, but I added a todo for it to be deprecated. -
core-ci voted on patch set 8 V +1 08/24/23, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45796
-
Benjamin Franzke rebased onto patch set 9
V +108/25/23, 05:03Rebase -
core-ci voted on patch set 9 V +1 08/25/23, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45810
-
Andreas Kienast voted on patch set 9 V +1 CR +1 08/25/23, 05:56
-
Christian Kuhn voted on patch set 9 V +1 08/28/23, 08:54
-
Benjamin Kott voted on patch set 9 V +1 CR +1 08/28/23, 13:44
-
Benjamin Franzke voted on patch set 9 V +2 CR +2 08/28/23, 13:45
-
Benjamin Franzke merged patch set 10 08/28/23, 14:47