Review main Abandoned

80595[FEATURE] Allow fieldControl=passwordGenerator for type=input,uuid

Garvin Hicking CR 0 V 0 Easy +49 −1 updated 08/23/23, 09:57

Commit message

Currently only the type=password TCA element allows to use
fieldControl=passwordGenerator. That shows a button for setting
a fresh password into a field.

Using type=password means that when displaying an existing record,
(or after saving) the field is no longer readable.

In cases where someone wants to use a passwordGenerator for some kind
of token generation, and these tokens to be readable on the FormEngine
after that, it is now possible to also use passwordGenerator on
type=input fields.

Also uuid fields have been enhanced to make use of it; they now support
also other fieldControl types.

Another follow-up on this might be to enhance the type=password TCA
field with a toggle that allows to show current password contents,
as long as 'hashed' is set to 'false' (working on this, seperate commit).

TODO: documentation for this change (seperate repository).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 58

  1. Garvin Hicking uploaded patch set 1 08/18/23, 09:16

  2. core-ci voted on patch set 1 V +1 08/18/23, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45598

  3. Garvin Hicking uploaded patch set 2 V +1 08/21/23, 16:02

  4. core-ci voted on patch set 2 V +1 08/21/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45652

  5. Garvin Hicking updated the commit message in patch set 3 V +1 08/21/23, 17:01

  6. core-ci voted on patch set 3 V +1 08/21/23, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45653

  7. Garvin Hicking commented on patch set 3 08/23/23, 06:58

  8. Garvin Hicking abandoned the change 08/23/23, 09:57