80596[BUGFIX] Allow a languageKey in non-Extbase f:translate VH
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Andreas Kienast +1
- Jörg Bösche +1
-
Verified V +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php2+8 −4
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/.gitignore1deleted+0 −2
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Private/Language/de-AT.locallang.xlfnew+11 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Private/Language/de.locallang.xlfnew+15 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Private/Language/locallang.xlfnew+28 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/composer.jsonnew+14 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/ext_emconf.phpnew+21 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+156 −22
Review log 1924
-
Benni Mack uploaded patch set 1 08/18/23, 10:59
-
core-ci voted on patch set 1 V +1 08/18/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45601
-
Benni Mack updated the commit message in patch set 2
V +108/18/23, 14:41 -
core-ci voted on patch set 2 V +1 08/18/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45607
-
Torben Hansen voted on patch set 2 V +1 CR +1 08/19/23, 10:07
-
Sybille Peters updated the commit message in patch set 3
CR +1V +108/19/23, 11:39 -
core-ci voted on patch set 3 V +1 08/19/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45618
-
Torben Hansen voted on patch set 3 V +1 CR +1 08/21/23, 08:15
-
Christian Kuhn commented on patch set 3 08/21/23, 13:56
-
Christian Kuhn commented on patch set 3 CR -1 08/21/23, 13:59
I think it would be good to extend functional tests here to find out about details. Maybe it's time to go away from the indexed_search tests and have a dedicated fixture extension that we can use in FE context as well. I'll try to figure something out. -1 working on it. -
Andreas Kienast voted on patch set 3 CR +1 08/21/23, 14:02
-
Christian Kuhn commented on patch set 3 08/22/23, 11:20
TranslateViewHelper.php:213ReplyYes, the VH does accept a locale object, so we'll keep this code. Next patch set comes with some tests that show this. -
Christian Kuhn uploaded patch set 4
CR +1V +108/22/23, 11:28 -
Christian Kuhn commented on patch set 4 08/22/23, 11:34
.gitignore:2removing this useless file as drive-by. -
core-ci voted on patch set 4 V +1 08/22/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45667
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/22/23, 11:39
-
Christian Kuhn updated the commit message in patch set 5
CR +1V +108/22/23, 11:40 -
Christian Kuhn voted on patch set 5 V +1 CR +1 08/22/23, 11:40
-
Torben Hansen voted on patch set 5 V +1 CR +1 08/22/23, 11:41
-
Andreas Kienast voted on patch set 5 V +1 CR +1 08/22/23, 11:41
-
core-ci voted on patch set 5 V +1 08/22/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45668
-
Jörg Bösche voted on patch set 5 CR +1 08/22/23, 11:52
-
Christian Kuhn voted on patch set 5 V +2 CR +2 08/22/23, 11:55
-
Christian Kuhn merged patch set 6 08/22/23, 11:56
TranslateViewHelper.php:213