Review main Merged

80598[TASK] Migrate @typo3/form/backend/form-editor/core to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +2102 −2296 updated 08/28/23, 14:46

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1827

Show 2 earlier messages
  1. Benjamin Franzke uploaded patch set 1 08/19/23, 13:36

    Unitial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/19/23, 13:37

    Reindent file
  1. Benjamin Franzke uploaded patch set 3 08/19/23, 13:38

    Apply eslint fix
  2. Benjamin Franzke uploaded patch set 4 08/19/23, 13:38

    Manual eslint fixes
  3. Benjamin Franzke uploaded patch set 5 08/19/23, 13:41

    Define types
  4. core-ci voted on patch set 2 V -1 08/19/23, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45625

  5. core-ci voted on patch set 4 V -1 08/19/23, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45627

  6. core-ci voted on patch set 3 V -1 08/19/23, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45626

  7. core-ci voted on patch set 5 V +1 08/19/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45628

  8. core-ci voted on patch set 1 V -1 08/19/23, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45624

  9. Andreas Kienast commented on patch set 5 V +1 CR +1 08/21/23, 13:40

    There are a few superfluous `@param` and `@return` annotations, but I'm confident this will be cleaned up at a later point.
  10. Benjamin Franzke marked it work in progress 08/22/23, 08:25

  11. Benjamin Franzke uploaded patch set 6 CR +1 V +1 08/23/23, 06:50

    Improve types
  12. core-ci voted on patch set 6 V +1 08/23/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45700

  13. Benjamin Franzke uploaded patch set 7 V +1 08/23/23, 07:30

    Remove debug output
  14. core-ci voted on patch set 7 V -1 08/23/23, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45737

  15. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  16. Benjamin Franzke uploaded patch set 8 V -1 08/23/23, 10:07

    Fix build
  17. core-ci voted on patch set 8 V +1 08/23/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45743

  18. Andreas Kienast voted on patch set 8 V +1 CR +1 08/23/23, 12:07

  19. Benjamin Franzke uploaded patch set 9 CR +1 V +1 08/25/23, 05:03

    Object.keys safeguard
  20. core-ci voted on patch set 9 V +1 08/25/23, 05:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45809

  21. Andreas Kienast voted on patch set 9 V +1 CR +1 08/25/23, 05:57

  22. Christian Kuhn voted on patch set 9 V +1 08/28/23, 08:58

  23. Benjamin Kott voted on patch set 9 V +1 CR +1 08/28/23, 13:43

  24. Benjamin Franzke voted on patch set 9 V +2 CR +2 08/28/23, 13:45

  25. Benjamin Franzke merged patch set 10 08/28/23, 14:46