80599[DOCS] Fix syntax error in changelog
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2330
Show 25 earlier messages
-
TYPO3com uploaded patch set 1 08/19/23, 17:06
-
core-ci voted on patch set 1 V +1 08/19/23, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45630
-
Simon Schaufelberger voted on patch set 1 V +1 CR +1 08/19/23, 17:20
-
Lina Wolf updated the commit message in patch set 2
CR +1V +108/19/23, 17:26 -
core-ci voted on patch set 2 V +1 08/19/23, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45631
-
Oliver Klee voted on patch set 2 V +1 CR +1 08/19/23, 19:45
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 08/20/23, 02:07
-
Sybille Peters voted on patch set 2 CR -1 08/20/23, 06:08
-
Sybille Peters uploaded patch set 3
CR +1V +108/20/23, 06:26 -
Sybille Peters uploaded patch set 4 08/20/23, 06:29
-
Sybille Peters uploaded patch set 5 08/20/23, 06:31
-
Sybille Peters commented on patch set 2 V +1 CR +1 08/20/23, 06:32
Checked the rendering locally. Looks ok now. No warnings (I use a method to only render one changelog for testing). While unrelated to this change, might as well make some more improvements to this changelog: 1. bullet lists should have a newline before and after, otherwise they will not be rendered correctly, see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html#impact: matches, setValue and isValid is a list 2. phrase "The following method has changed first argument to an :php:`int`" reads a bit awkward. Did the method change the first argument or did someone change the first argument in the method? Also, it is not really correct: it was an int before, it just got a typehint now: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78188/13/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php 3. \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation::method should be \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation 4. "calling public methods methods" should be "calling public methods" -
core-ci voted on patch set 3 V +1 08/20/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45635
-
core-ci voted on patch set 5 V +1 08/20/23, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45637
-
core-ci voted on patch set 4 V +1 08/20/23, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45636
-
Lina Wolf commented on patch set 5 08/20/23, 07:41
I do agree with your suggestions, but please commit them in a follow up. This change is intended as a quick fix to repair a currently broken output, not a general review of the complete chapter -
Lina Wolf commented on patch set 5 CR -1 08/20/23, 07:48
Breaking-100229-ConvertJSConfirmationToBitSet.rst:18Changes of complete sentences are way beyond the intention of this change. Please do a follow up if you want to make these kind of changesBreaking-100229-ConvertJSConfirmationToBitSet.rst:45I believe you are changing the meaning here. the original author would have to agree -
Sybille Peters uploaded patch set 6
CR -1V +108/20/23, 08:26 -
Sybille Peters commented on patch set 5 08/20/23, 08:27
Breaking-100229-ConvertJSConfirmationToBitSet.rst:18ReplyPushed patchset 2 again. Will create new patch -
Sybille Peters commented on patch set 6 08/20/23, 08:32
Breaking-100229-ConvertJSConfirmationToBitSet.rst:45ReplyChange reverted. Will handle in different patch. -
Sybille Peters wrote 08/20/23, 08:32
Removed reviewer Sybille Peters. -
core-ci voted on patch set 6 V +1 08/20/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45639
-
Lina Wolf voted on patch set 6 CR +1 08/20/23, 08:35
-
Oliver Klee commented on patch set 6 V +1 CR +1 08/20/23, 08:36
I’m a big fan of “one kind of change per PR/change” and of “only change what is related to what the commit message subject states”! -
Simon Schaufelberger voted on patch set 6 V +1 CR +1 08/20/23, 13:48
-
Sybille Peters voted on patch set 6 V +1 CR +1 08/21/23, 07:05
-
Christian Kuhn voted on patch set 6 V +2 CR +2 08/21/23, 08:50
-
Christian Kuhn uploaded patch set 7 08/21/23, 08:51
Copied Votes: * Code-Review+1, Code-Review+2 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1, Verified+2 (copy condition: "changekind:NO_CHANGE") -
Christian Kuhn voted on patch set 7 V 0 CR 0 08/21/23, 08:53
-
Christian Kuhn abandoned the change 08/21/23, 08:53