Review 12.4 Merged

80614[BUGFIX] Allow a languageKey in non-Extbase f:translate VH

Christian Kuhn CR +2 V +2 Hard +254 −28 updated 08/22/23, 11:56

Commit message

Even though the <f:translate> ViewHelper has a "languageKey"
argument, the parameter was only evaluated for Extbase
requests. However, it should also be possible for non-Extbase
Fluid parts - such as Fluid emails.

The patch adds the "languageKey" handling and refactors the
tests to rely on a fixture extension. Tests are added for
"languageKey" scenarios including fallback chains.

The new tests reveal a bug in extbase LocalizationUtility with
fallback chains along the way, keeps according tests as skipped,
and adds `@todo` for further investigation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 9

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/22/23, 11:46

  2. core-ci voted on patch set 1 V +1 08/22/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45670

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 08/22/23, 11:56

  4. Christian Kuhn merged patch set 2 08/22/23, 11:56