Review main Merged

80619[TASK] Verify @-sign is a valid TypoScript identifier

Christian Kuhn CR +2 V +2 Easy +47 −0 updated 08/22/23, 13:54

Commit message

ext:form tends to use email addresses as
TypoScript identifier. The old TS parser
did not deal with this, the new one does.

The patch adds tests to the TS tokenizer
to verify this works.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 08/22/23, 13:04

  2. core-ci voted on patch set 1 V +1 08/22/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45681

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 08/22/23, 13:31

  4. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 08/22/23, 13:31

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 08/22/23, 13:36

  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/22/23, 13:37

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 08/22/23, 13:54

  8. Christian Kuhn merged patch set 2 08/22/23, 13:54