Review main Merged

80624[TASK] Migrate @typo3/form/backend/form-editor/modals-component to TypeScript

Benjamin Franzke CR +2 V +2 Hard +437 −545 updated 08/28/23, 14:49

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1417

  1. Benjamin Franzke uploaded patch set 1 08/23/23, 06:51

    Initial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/23/23, 06:52

    Reindent file
  3. Benjamin Franzke uploaded patch set 3 08/23/23, 06:54

    Apply eslint fix
  4. Benjamin Franzke uploaded patch set 4 08/23/23, 07:02

    Manual eslint fixes
  5. Benjamin Franzke uploaded patch set 5 08/23/23, 07:05

    Define types
  6. core-ci voted on patch set 5 V +1 08/23/23, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45709

  7. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  8. Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/23, 14:11

  9. Benjamin Franzke rebased onto patch set 6 CR +1 V +1 08/24/23, 18:27

    Rebase
  10. core-ci voted on patch set 6 V +1 08/24/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45798

  11. Benjamin Franzke rebased onto patch set 7 V +1 08/25/23, 05:03

    Rebase
  12. core-ci voted on patch set 7 V +1 08/25/23, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45812

  13. Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:56

  14. Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:55

  15. Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44

  16. Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46

  17. Benjamin Franzke merged patch set 8 08/28/23, 14:49